Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1511474
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 4/6] Input: gpio_keys - fix leaking DT node references |
| Date | 2016-10-29 01:20 +0200 |
| Message-ID | <sxoBj-6pf-1@gated-at.bofh.it> (permalink) |
| References | <sxoBj-6pf-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
for_each_available_child_of_node(node, pp) takes reference to 'pp' and
drops it when attempting next iteration. However if we exit the loop early
we need to drop the reference ourselves.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/keyboard/gpio_keys.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index 8f7c20b..d75a25c 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -659,6 +659,7 @@ gpio_keys_get_devtree_pdata(struct device *dev)
dev_err(dev,
"Failed to get gpio flags, error: %d\n",
error);
+ of_node_put(pp);
return ERR_PTR(error);
}
} else {
@@ -669,12 +670,14 @@ gpio_keys_get_devtree_pdata(struct device *dev)
if (!gpio_is_valid(button->gpio) && !button->irq) {
dev_err(dev, "Found button without gpios or irqs\n");
+ of_node_put(pp);
return ERR_PTR(-EINVAL);
}
if (of_property_read_u32(pp, "linux,code", &button->code)) {
dev_err(dev, "Button without keycode: 0x%x\n",
button->gpio);
+ of_node_put(pp);
return ERR_PTR(-EINVAL);
}
--
2.8.0.rc3.226.g39d4020
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 4/6] Input: gpio_keys - fix leaking DT node references Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-10-29 01:20 +0200
csiph-web