Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1511408

[PATCH v2 1/6] net: phy: broadcom: add bcm54xx_auxctl_read

Show all headers | View raw

Add a helper function to read the AUXCTL register for the BCM54xx.  This
mirrors the bcm54xx_auxctl_write function already present in the code.

Signed-off-by: Jon Mason <jon.mason@broadcom.com>
---
 drivers/net/phy/broadcom.c | 10 ++++++++++
 include/linux/brcmphy.h    |  1 +
 2 files changed, 11 insertions(+)

diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index 583ef8a..3a64b3d 100644
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -30,6 +30,16 @@ MODULE_DESCRIPTION("Broadcom PHY driver");
 MODULE_AUTHOR("Maciej W. Rozycki");
 MODULE_LICENSE("GPL");
 
+static int bcm54xx_auxctl_read(struct phy_device *phydev, u16 regnum)
+{
+	/* The register must be written to both the Shadow Register Select and
+	 * the Shadow Read Register Selector
+	 */
+	phy_write(phydev, MII_BCM54XX_AUX_CTL, regnum |
+		  regnum << MII_BCM54XX_AUXCTL_SHDWSEL_READ_SHIFT);
+	return phy_read(phydev, MII_BCM54XX_AUX_CTL);
+}
+
 static int bcm54xx_auxctl_write(struct phy_device *phydev, u16 regnum, u16 val)
 {
 	return phy_write(phydev, MII_BCM54XX_AUX_CTL, regnum | val);
diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h
index 60def78..0ed6691 100644
--- a/include/linux/brcmphy.h
+++ b/include/linux/brcmphy.h
@@ -110,6 +110,7 @@
 #define MII_BCM54XX_AUXCTL_MISC_FORCE_AMDIX	0x0200
 #define MII_BCM54XX_AUXCTL_MISC_RDSEL_MISC	0x7000
 #define MII_BCM54XX_AUXCTL_SHDWSEL_MISC	0x0007
+#define MII_BCM54XX_AUXCTL_SHDWSEL_READ_SHIFT	12
 
 #define MII_BCM54XX_AUXCTL_SHDWSEL_MASK	0x0007
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/6] add NS2 support to bgmac Jon Mason <jon.mason@broadcom.com> - 2016-10-28 23:00 +0200
  [PATCH v2 1/6] net: phy: broadcom: add bcm54xx_auxctl_read Jon Mason <jon.mason@broadcom.com> - 2016-10-28 23:00 +0200
  [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry Jon Mason <jon.mason@broadcom.com> - 2016-10-28 23:00 +0200
    Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry Andrew Lunn <andrew@lunn.ch> - 2016-10-29 10:20 +0200
      Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry Jon Mason <jon.mason@broadcom.com> - 2016-11-01 17:10 +0100
        Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry Andrew Lunn <andrew@lunn.ch> - 2016-11-01 17:30 +0100
          Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry Jon Mason <jon.mason@broadcom.com> - 2016-11-01 17:50 +0100
            Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry Andrew Lunn <andrew@lunn.ch> - 2016-11-01 18:00 +0100
  [PATCH v2 4/6] net: ethernet: bgmac: device tree phy enablement Jon Mason <jon.mason@broadcom.com> - 2016-10-28 23:00 +0200
  [PATCH v2 5/6] net: ethernet: bgmac: add NS2 support Jon Mason <jon.mason@broadcom.com> - 2016-10-28 23:00 +0200

csiph-web