Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1511334

Re: [PATCH] mac80211: fix incorrect error return path on tmp allocation failure

Show all headers | View raw

On Fri, 2016-10-28 at 19:08 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The current exit path when tmp fails to be allocated is via the
> fail label which frees tfm2 which has not yet been allocated,
> which is problematic since tfm2 is not initialized and is a garbage
> pointer. Fix this by exiting directly to the return at the end
> of the function and hence avoiding the freeing of tfm2.

Yeah, thanks. Arnd beat you to the fix by about 8 hours, so I've
already applied his patch and sent an updated pull request :)

johannes

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mac80211: fix incorrect error return path on tmp allocation failure Colin King <colin.king@canonical.com> - 2016-10-28 20:10 +0200
  Re: [PATCH] mac80211: fix incorrect error return path on tmp  allocation failure Johannes Berg <johannes@sipsolutions.net> - 2016-10-28 20:30 +0200

csiph-web