Re: [PATCH v3 0/5] Cavium ThunderX uncore PMU support

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 0/5] Cavium ThunderX uncore PMU support
Date	2016-10-28 17:50 +0200
Message-ID	<sxhzQ-1Im-3@gated-at.bofh.it> (permalink)
References	<suhZn-5G9-3@gated-at.bofh.it> <suiVs-6l9-17@gated-at.bofh.it> <sujRv-6UT-3@gated-at.bofh.it> <sxh6O-1yj-9@gated-at.bofh.it> <sxhzQ-1Im-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 28, 2016 at 05:36:46PM +0200, Jan Glauber wrote:
> On Fri, Oct 28, 2016 at 04:17:49PM +0100, Will Deacon wrote:
> > On Thu, Oct 20, 2016 at 01:23:51PM +0200, Jan Glauber wrote:
> > > On Thu, Oct 20, 2016 at 12:37:07PM +0200, Peter Zijlstra wrote:
> > > > On Thu, Oct 20, 2016 at 11:30:36AM +0200, Jan Glauber wrote:
> > > > > Note:
> > > > > I'm using perf_sw_context in difference to perf_invalid_context
> > > > > (see WARN_ON in perf_pmu_register). Reason is that with perf_invalid_context
> > > > > add() is never called and the counter results are shown as "unsupported" by
> > > > > perf. With perf_sw_context everything works as expected.
> > > > 
> > > > What?! All the uncore PMUs use perf_invalid_context. What doesn't work
> > > > for you?
> > > 
> > > OK, so using perf_invalid_context and "-a" seems to work.
> > > 
> > > But I must say that I hate that from a user perspective. The user needs to know about
> > > the type of PMU behind the event and then provide "-a" or get a "<not supported"
> > > as counter value?
> > 
> > Sure, but in the interest of getting *something* merged, can we start
> > off using perf_invalid_context and then have the discussion about whether
> > or not this can be extended later on, please? If your PMU is a shared
> > resource amongst CPUs, it maybe that all you want is a better error
> > message from the perf tool (but again, this can come later!).
> 
> If that is the only obstacle I can repost with perf_sw_context (or do a
> follow-up patch). After all it works, it is just "clueless" people like
> me that are not aware of the required switches.

Please send a version using perf_invalid_context (which I assume is what
you meant above).

Thanks,
Mark.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 0/5] Cavium ThunderX uncore PMU support Will Deacon <will.deacon@arm.com> - 2016-10-28 17:20 +0200
  Re: [PATCH v3 0/5] Cavium ThunderX uncore PMU support Mark Rutland <mark.rutland@arm.com> - 2016-10-28 17:50 +0200

csiph-web