Re: [PATCH v2] net: cpsw: fix obtaining mac address for am3517

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] net: cpsw: fix obtaining mac address for am3517
Date	2016-10-28 18:00 +0200
Message-ID	<sxhJw-1LS-39@gated-at.bofh.it> (permalink)
References	<sxhJw-1LS-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Jeroen Hofstee <jhofstee@victronenergy.com> [161028 08:33]:
> Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
> id to common file") did not only move the code for an am3517, it also
> added the slave parameter, resulting in an invalid (all zero) mac address
> being returned for an am3517, since it only has a single emac and the slave
> parameter is pointing to the second. So simply always read the first and
> valid mac-address for a ti,am3517-emac.

And others davinci_emac.c users can have more than one. So is the
reason the slave parameter points to the second instance because
of the location in the hardware?

Regards,

Tony

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] net: cpsw: fix obtaining mac address for am3517 Tony Lindgren <tony@atomide.com> - 2016-10-28 18:00 +0200
  Re: [PATCH v2] net: cpsw: fix obtaining mac address for am3517 Tony Lindgren <tony@atomide.com> - 2016-10-28 20:30 +0200

csiph-web