Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1511110

[PATCH v2 8/8] mfd: tps65217: Fix mismatched interrupt number

Show all headers | View raw

Enum value of 'tps65217_irq_type' is not matched with DT parsed hwirq
number[*].

The MFD driver gets the IRQ data by referencing hwirq, but the value is
different. So, irq_to_tps65217_irq() returns mismatched IRQ data.
Eventually, the power button driver enables not PB but USB interrupt
when it is probed.

According to the TPS65217 register map[**], USB interrupt is the LSB.
This patch defines synchronized IRQ value.

[*]  include/dt-bindings/mfd/tps65217.h
[**] http://www.ti.com/lit/ds/symlink/tps65217.pdf

Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
---
 include/linux/mfd/tps65217.h | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/include/linux/mfd/tps65217.h b/include/linux/mfd/tps65217.h
index 4ccda89..3cbec4b 100644
--- a/include/linux/mfd/tps65217.h
+++ b/include/linux/mfd/tps65217.h
@@ -234,12 +234,11 @@ struct tps65217_bl_pdata {
 	int dft_brightness;
 };
 
-enum tps65217_irq_type {
-	TPS65217_IRQ_PB,
-	TPS65217_IRQ_AC,
-	TPS65217_IRQ_USB,
-	TPS65217_NUM_IRQ
-};
+/* Interrupt numbers */
+#define TPS65217_IRQ_USB		0
+#define TPS65217_IRQ_AC			1
+#define TPS65217_IRQ_PB			2
+#define TPS65217_NUM_IRQ		3
 
 /**
  * struct tps65217_board - packages regulator init data
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/8] Support TPS65217 PMIC interrupt in DT Milo Kim <woogyom.kim@gmail.com> - 2016-10-28 14:40 +0200
  [PATCH v2 3/8] ARM: dts: tps65217: Add the power button device Milo Kim <woogyom.kim@gmail.com> - 2016-10-28 14:40 +0200
  [PATCH v2 2/8] ARM: dts: tps65217: Add the charger device Milo Kim <woogyom.kim@gmail.com> - 2016-10-28 14:40 +0200
  [PATCH v2 5/8] dt-bindings: mfd: Provide human readable defines for TPS65217 interrupts Milo Kim <woogyom.kim@gmail.com> - 2016-10-28 14:40 +0200
  [PATCH v2 8/8] mfd: tps65217: Fix mismatched interrupt number Milo Kim <woogyom.kim@gmail.com> - 2016-10-28 14:40 +0200
  Re: [PATCH v2 0/8] Support TPS65217 PMIC interrupt in DT Tony Lindgren <tony@atomide.com> - 2016-11-09 22:40 +0100

csiph-web