Re: [PATCH] mac80211: fils_aead: fix encrypt error handling

From	Johannes Berg <johannes@sipsolutions.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mac80211: fils_aead: fix encrypt error handling
Date	2016-10-28 13:00 +0200
Message-ID	<sxd3b-7ff-21@gated-at.bofh.it> (permalink)
References	<sxcAa-73j-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2016-10-28 at 12:25 +0200, Arnd Bergmann wrote:
> gcc -Wmaybe-uninitialized reports a bug in aes_siv_encryp:
> 
> net/mac80211/fils_aead.c: In function ‘aes_siv_encrypt.constprop’:
> net/mac80211/fils_aead.c:84:26: error: ‘tfm2’ may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
> 
> At the time that the memory allocation fails, 'tfm2' has not been
> allocated, so we should not attempt to free it later, and we can
> simply return an error.
> 
> Fixes: 39404feee691 ("mac80211: FILS AEAD protection for station mode
> association frames")

Ahrg, how did I miss that.

Dave, I'll apply this, and send a new pull request.

johannes

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mac80211: fils_aead: fix encrypt error handling Arnd Bergmann <arnd@arndb.de> - 2016-10-28 12:30 +0200
  Re: [PATCH] mac80211: fils_aead: fix encrypt error handling Johannes Berg <johannes@sipsolutions.net> - 2016-10-28 13:00 +0200

csiph-web