[PATCH 03/10] staging: iio: tsl2583: return proper error code instead of -1

From	Brian Masney <masneyb@onstation.org>
Newsgroups	linux.kernel
Subject	[PATCH 03/10] staging: iio: tsl2583: return proper error code instead of -1
Date	2016-10-28 12:10 +0200
Message-ID	<sxcgO-6SN-19@gated-at.bofh.it> (permalink)
References	<sxcgN-6SN-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

taos_als_calibrate() has a code path where -1 is returned. This patch
changes the code so that a proper error code is returned.

Signed-off-by: Brian Masney <masneyb@onstation.org>
---
 drivers/staging/iio/light/tsl2583.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
index 35c1696..47fd373 100644
--- a/drivers/staging/iio/light/tsl2583.c
+++ b/drivers/staging/iio/light/tsl2583.c
@@ -373,7 +373,7 @@ static int taos_als_calibrate(struct iio_dev *indio_dev)
 			!= (TSL258X_CNTL_ADC_ENBL | TSL258X_CNTL_PWR_ON)) {
 		dev_err(&chip->client->dev,
 			"taos_als_calibrate failed: device not powered on with ADC enabled\n");
-		return -1;
+		return -EINVAL;
 	}
 
 	ret = i2c_smbus_write_byte(chip->client,
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 03/10] staging: iio: tsl2583: return proper error code instead of -1 Brian Masney <masneyb@onstation.org> - 2016-10-28 12:10 +0200
  Re: [PATCH 03/10] staging: iio: tsl2583: return proper error code  instead of -1 Jonathan Cameron <jic23@kernel.org> - 2016-10-30 19:00 +0100

csiph-web