Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1511010

[PATCH] ubifs: Fix regression in ubifs_readdir()

Show all headers | View raw

Commit c83ed4c9dbb35 ("ubifs: Abort readdir upon error") broke
overlayfs support because the fix exposed an internal error
code to VFS.

Reported-by: Peter Rosin <peda@axentia.se>
Tested-by: Peter Rosin <peda@axentia.se>
Reported-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Fixes: c83ed4c9dbb35 ("ubifs: Abort readdir upon error")
Cc: stable@vger.kernel.org
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 fs/ubifs/dir.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index bd4a5e8ce441..ca16c5d7bab1 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -543,6 +543,14 @@ static int ubifs_readdir(struct file *file, struct dir_context *ctx)
 
 	if (err != -ENOENT)
 		ubifs_err(c, "cannot find next direntry, error %d", err);
+	else
+		/*
+		 * -ENOENT is a non-fatal error in this context, the TNC uses
+		 * it to indicate that the cursor moved past the current directory
+		 * and readdir() has to stop.
+		 */
+		err = 0;
+
 
 	/* 2 is a special value indicating that there are no more direntries */
 	ctx->pos = 2;
-- 
2.7.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ubifs: Fix regression in ubifs_readdir() Richard Weinberger <richard@nod.at> - 2016-10-28 12:00 +0200
  Re: [PATCH] ubifs: Fix regression in ubifs_readdir() Jörg Krause <joerg.krause@embedded.rocks> - 2016-10-28 18:20 +0200
    Re: [PATCH] ubifs: Fix regression in ubifs_readdir() Richard Weinberger <richard@nod.at> - 2016-10-28 19:10 +0200
      Re: [PATCH] ubifs: Fix regression in ubifs_readdir() Jörg Krause <joerg.krause@embedded.rocks> - 2016-10-29 00:30 +0200
        Re: [PATCH] ubifs: Fix regression in ubifs_readdir() Richard Weinberger <richard@nod.at> - 2016-10-29 11:10 +0200

csiph-web