Re: [PATCH] UBI: fastmap: Fix add_vol() return value test in ubi_attach_fastmap()

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: [PATCH] UBI: fastmap: Fix add_vol() return value test in ubi_attach_fastmap()
Date	2016-10-28 11:20 +0200
Message-ID	<sxbup-6lx-15@gated-at.bofh.it> (permalink)
References	<sxbkJ-6ib-1@gated-at.bofh.it> <sxbup-6lx-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 28.10.2016 11:12, Boris Brezillon wrote:
> On Fri, 28 Oct 2016 11:08:44 +0200
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> 
>> Commit e96a8a3bb671 ("UBI: Fastmap: Do not add vol if it already
>> exists") introduced a bug by changing the possible error codes returned
>> by add_vol():
>> - this functions no longer returns NULL in case of allocation failure
> 
> 	 ^ function
> 
>>   but return ERR_PTR(-ENOMEM)
>> - when a duplicate entry in the volume RB tree is found it returns
>>   ERR_PTR(-EEXIST) instead of ERR_PTR(-EINVAL)
>>
>> Fix the tests done of add_vol() return value accordingly.
> 
> "Fix the tests done on add_vol() return val to match this new behavior."
> 
> Do you want me to send a new version fixing the commit message?

Nope, I can fixup it myself. :-)

Thanks,
//richard

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] UBI: fastmap: Fix add_vol() return value test in ubi_attach_fastmap() Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-10-28 11:10 +0200
  Re: [PATCH] UBI: fastmap: Fix add_vol() return value test in  ubi_attach_fastmap() Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-10-28 11:20 +0200
    Re: [PATCH] UBI: fastmap: Fix add_vol() return value test in  ubi_attach_fastmap() Richard Weinberger <richard@nod.at> - 2016-10-28 11:20 +0200

csiph-web