Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1510920

Re: [RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization Tracking

From Vikram Mulukutla <markivx@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization Tracking
Date 2016-10-28 10:00 +0200
Message-ID <sxaeZ-5mE-17@gated-at.bofh.it> (permalink)
References <sx9Ch-59A-3@gated-at.bofh.it> <sx9Ch-59A-1@gated-at.bofh.it> <sxa5j-5je-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 2016-10-28 00:43, Peter Zijlstra wrote:
> On Fri, Oct 28, 2016 at 12:10:41AM -0700, Vikram Mulukutla wrote:
>> +u64 walt_ktime_clock(void)
>> +{
>> +	if (unlikely(walt_ktime_suspended))
>> +		return ktime_to_ns(ktime_last);
>> +	return ktime_get_ns();
>> +}
> 
>> +static int walt_suspend(void)
>> +{
>> +	ktime_last = ktime_get();
>> +	walt_ktime_suspended = true;
>> +	return 0;
>> +}
> 
> No, ktime_get() will not be used in the scheduler. Imagine the joy if
> that thing ends up being the HPET.

Agreed, this is an artifact from the full implementation that feeds into 
the
interactive governor, and thus both needed to use the same time source. 
It
shall go away.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization Tracking Vikram Mulukutla <markivx@codeaurora.org> - 2016-10-28 09:20 +0200
  Re: [RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization  Tracking Peter Zijlstra <peterz@infradead.org> - 2016-10-28 09:40 +0200
  Re: [RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization  Tracking Peter Zijlstra <peterz@infradead.org> - 2016-10-28 09:50 +0200
    Re: [RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization  Tracking Vikram Mulukutla <markivx@codeaurora.org> - 2016-10-28 10:10 +0200
  Re: [RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization  Tracking Peter Zijlstra <peterz@infradead.org> - 2016-10-28 09:50 +0200
    Re: [RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization  Tracking Vikram Mulukutla <markivx@codeaurora.org> - 2016-10-28 10:00 +0200
  Re: [RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization  Tracking Peter Zijlstra <peterz@infradead.org> - 2016-10-28 10:00 +0200

csiph-web