Re: [PATCH -v4 RESEND 6/9] mm, THP, swap: Support to add/delete THP to/from swap cache

From	"Huang\, Ying" <ying.huang@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH -v4 RESEND 6/9] mm, THP, swap: Support to add/delete THP to/from swap cache
Date	2016-10-28 10:40 +0200
Message-ID	<sxaRI-5SO-41@gated-at.bofh.it> (permalink)
References	<sx8mR-49C-1@gated-at.bofh.it> <sx8mR-49C-3@gated-at.bofh.it> <sxayl-5Mi-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Hillf,

Hillf Danton <hillf.zj@alibaba-inc.com> writes:

> On Friday, October 28, 2016 1:56 PM Huang, Ying wrote:
>> 
>> @@ -109,9 +118,16 @@ int __add_to_swap_cache(struct page *page, swp_entry_t entry)
>>  		 * So add_to_swap_cache() doesn't returns -EEXIST.
>>  		 */
>>  		VM_BUG_ON(error == -EEXIST);
>> -		set_page_private(page, 0UL);
>>  		ClearPageSwapCache(page);
>> -		put_page(page);
>> +		set_page_private(cur_page, 0UL);
>> +		while (i--) {
>> +			cur_page--;
>> +			cur_entry.val--;
>> +			set_page_private(cur_page, 0UL);
>> +			radix_tree_delete(&address_space->page_tree,
>> +					  swp_offset(cur_entry));
>> +		}
>
> Pull pages out of radix tree with tree lock held?

OOPS, I should hold the tree lock for the error path too.  Will update
it in the next version.  Thanks for pointing out this!

Best Regards,
Huang, Ying


>> +		page_ref_sub(page, nr);
>>  	}
>> 
>>  	return error;
>>

Thread

[PATCH -v4 RESEND 0/9] THP swap: Delay splitting THP during swapping out "Huang, Ying" <ying.huang@intel.com> - 2016-10-28 08:00 +0200
  [PATCH -v4 RESEND 5/9] mm, THP, swap: Support to clear SWAP_HAS_CACHE for huge page "Huang, Ying" <ying.huang@intel.com> - 2016-10-28 08:00 +0200
  [PATCH -v4 RESEND 9/9] mm, THP, swap: Delay splitting THP during swap out "Huang, Ying" <ying.huang@intel.com> - 2016-10-28 08:00 +0200
  [PATCH -v4 RESEND 6/9] mm, THP, swap: Support to add/delete THP to/from swap cache "Huang, Ying" <ying.huang@intel.com> - 2016-10-28 08:00 +0200
    Re: [PATCH -v4 RESEND 6/9] mm, THP, swap: Support to add/delete THP to/from swap cache "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-10-28 10:20 +0200
      Re: [PATCH -v4 RESEND 6/9] mm, THP, swap: Support to add/delete THP to/from swap cache "Huang\, Ying" <ying.huang@intel.com> - 2016-10-28 10:40 +0200
  [PATCH -v4 RESEND 8/9] mm, THP, swap: Support to split THP in swap cache "Huang, Ying" <ying.huang@intel.com> - 2016-10-28 08:00 +0200
    Re: [PATCH -v4 RESEND 8/9] mm, THP, swap: Support to split THP in swap cache "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-10-28 12:20 +0200
      Re: [PATCH -v4 RESEND 8/9] mm, THP, swap: Support to split THP in swap cache "Huang\, Ying" <ying.huang@intel.com> - 2016-10-31 02:30 +0100
  [PATCH -v4 RESEND 4/9] mm, THP, swap: Add get_huge_swap_page() "Huang, Ying" <ying.huang@intel.com> - 2016-10-28 08:00 +0200
  [PATCH -v4 RESEND 1/9] mm, swap: Make swap cluster size same of THP size on x86_64 "Huang, Ying" <ying.huang@intel.com> - 2016-10-28 08:00 +0200
  [PATCH -v4 RESEND 3/9] mm, THP, swap: Add swap cluster allocate/free functions "Huang, Ying" <ying.huang@intel.com> - 2016-10-28 08:00 +0200
  [PATCH -v4 RESEND 7/9] mm, THP: Add can_split_huge_page() "Huang, Ying" <ying.huang@intel.com> - 2016-10-28 08:00 +0200
  [PATCH -v4 RESEND 2/9] mm, memcg: Support to charge/uncharge multiple swap entries "Huang, Ying" <ying.huang@intel.com> - 2016-10-28 08:10 +0200

csiph-web