Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1512081

Re: [PATCH 22/29] staging: lustre: llite: add LL_IOC_FUTIMES_3

Show all headers | View raw

On Thu, Oct 27, 2016 at 06:11:56PM -0400, James Simmons wrote:
> From: John L. Hammond <john.hammond@intel.com>
> 
> Add a new regular file ioctl LL_IOC_FUTIMES_3 similar to futimes() but
> which allows setting of all three inode timestamps. Use this ioctl
> during HSM restore to ensure that the volatile file has the same
> timestamps as the file to be restored. Strengthen sanity-hsm test_24a
> to check that archive, release, and restore do not change a file's
> ctime. Add sanity-hsm test_24e to check that tar will succeed when it
> encounters a HSM released file.

This sounds odd, why is this filesystem the only one that needs a
"special" futimes?  Don't make up new syscalls by making an ioctl
please, make a new syscall if that's what you really need!

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/29] Batch one for work from 2.7.55 to 2.7.59 James Simmons <jsimmons@infradead.org> - 2016-10-28 00:20 +0200
  [PATCH 27/29] staging: lustre: headers: Create single .h for lu_seq_range James Simmons <jsimmons@infradead.org> - 2016-10-28 00:20 +0200
  [PATCH 03/29] staging: lustre: llite: restart short read/write for normal IO James Simmons <jsimmons@infradead.org> - 2016-10-28 00:20 +0200
  [PATCH 22/29] staging: lustre: llite: add LL_IOC_FUTIMES_3 James Simmons <jsimmons@infradead.org> - 2016-10-28 00:20 +0200
    Re: [PATCH 22/29] staging: lustre: llite: add LL_IOC_FUTIMES_3 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-30 16:10 +0100
      Re: [PATCH 22/29] staging: lustre: llite: add LL_IOC_FUTIMES_3 James Simmons <jsimmons@infradead.org> - 2016-11-07 04:50 +0100
  [PATCH 04/29] staging: lustre: obdclass: variable llog chunk size James Simmons <jsimmons@infradead.org> - 2016-10-28 00:20 +0200
  [PATCH 23/29] staging: lustre: ptlrpc: do not sleep if encpool reached max capacity James Simmons <jsimmons@infradead.org> - 2016-10-28 00:20 +0200

csiph-web