Re: [PATCH] HID: intel-ish-hid: Fix !CONFIG_PM build warning

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!newsfeed.datemas.de!enother.net!enother.net!enother.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] HID: intel-ish-hid: Fix !CONFIG_PM build warning
Date	Sat, 29 Oct 2016 18:00:01 +0200
Message-ID	<sxEd3-89L-3@gated-at.bofh.it> (permalink)
References	<sxzQ5-5uj-7@gated-at.bofh.it>
X-Original-To	Borislav Petkov <bp@alien8.de>, LKML <linux-kernel@vger.kernel.org>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.31,564,1473145200"; d="scan'208";a="25138389"
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.18.5.2 (3.18.5.2-1.fc23)
MIME-Version	1.0
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	58
Organization	linux.* mail to news gateway
X-Original-Cc	Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Wei Yongjun <weiyongjun1@huawei.com>, linux-input@vger.kernel.org
X-Original-Date	Sat, 29 Oct 2016 08:49:23 -0700
X-Original-Message-ID	<1477756163.8025.0.camel@linux.intel.com>
X-Original-References	<20161029111740.741-1-bp@alien8.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1511827

Show key headers only | View raw

On Sat, 2016-10-29 at 13:17 +0200, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> 
> Fix
> 
>   drivers/hid/intel-ish-hid/ipc/pci-ish.c:247:12: warning:
> ‘ish_suspend’ defined but not used [-Wunused-function]
>    static int ish_suspend(struct device *device)
>               ^
>   drivers/hid/intel-ish-hid/ipc/pci-ish.c:282:12: warning:
> ‘ish_resume’ defined but not used [-Wunused-function]
>    static int ish_resume(struct device *device)
>             ^
> by sticking them in the CONFIG_PM range too.
> 
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: Wei Yongjun <weiyongjun1@huawei.com>
> Cc: linux-input@vger.kernel.org

Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>-

> ---
>  drivers/hid/intel-ish-hid/ipc/pci-ish.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> index 42f0beeb09fd..7e3622a724aa 100644
> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> @@ -202,6 +202,7 @@ static void ish_remove(struct pci_dev *pdev)
>  	kfree(ishtp_dev);
>  }
>  
> +#ifdef CONFIG_PM
>  static struct device *ish_resume_device;
>  
>  /**
> @@ -293,7 +294,6 @@ static int ish_resume(struct device *device)
>  	return 0;
>  }
>  
> -#ifdef CONFIG_PM
>  static const struct dev_pm_ops ish_pm_ops = {
>  	.suspend = ish_suspend,
>  	.resume = ish_resume,
> @@ -301,7 +301,7 @@ static const struct dev_pm_ops ish_pm_ops = {
>  #define ISHTP_ISH_PM_OPS	(&ish_pm_ops)
>  #else
>  #define ISHTP_ISH_PM_OPS	NULL
> -#endif
> +#endif /* CONFIG_PM */
>  
>  static struct pci_driver ish_driver = {
>  	.name = KBUILD_MODNAME,

Thread

[PATCH] HID: intel-ish-hid: Fix !CONFIG_PM build warning Borislav Petkov <bp@alien8.de> - 2016-10-29 13:20 +0200
  Re: [PATCH] HID: intel-ish-hid: Fix !CONFIG_PM build warning Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-10-29 18:00 +0200
  Re: [PATCH] HID: intel-ish-hid: Fix !CONFIG_PM build warning Jiri Kosina <jikos@kernel.org> - 2016-11-03 19:20 +0100

csiph-web