Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1510836
| From | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/4] printk/NMI: Handle continuous lines and missing newline |
| Date | 2016-10-28 06:10 +0200 |
| Message-ID | <sx6Ep-3dL-9@gated-at.bofh.it> (permalink) |
| References | <swVfX-3Pm-7@gated-at.bofh.it> <swVfY-3Pm-27@gated-at.bofh.it> <swVSF-4lA-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On (10/27/16 09:35), Joe Perches wrote:
[..]
> > - printk_nmi_flush_line(buf, (end - start) + 1);
> > + /* Handle continuous lines or missing new line. */
> > + if ((c + 1 < end) && printk_get_level(c)) {
> > + if (header) {
> > + c += 2;
>
> printk_skip_level
agree, printk_skip_level() probably would look better here.
other than that, looks good to me. nice that you found it, Petr!
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/4] printk/NMI: Handle continuous lines and missing newline Petr Mladek <pmladek@suse.com> - 2016-10-27 18:00 +0200
Re: [PATCH 1/4] printk/NMI: Handle continuous lines and missing newline Joe Perches <joe@perches.com> - 2016-10-27 18:40 +0200
Re: [PATCH 1/4] printk/NMI: Handle continuous lines and missing newline Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-10-28 06:10 +0200
Re: [PATCH 1/4] printk/NMI: Handle continuous lines and missing newline David Sterba <dsterba@suse.cz> - 2016-10-31 10:00 +0100
csiph-web