Re: [PATCH 7/7] mfd: tps65217: Fix mismatched interrupt number

From	Milo Kim <woogyom.kim@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/7] mfd: tps65217: Fix mismatched interrupt number
Date	2016-10-28 06:10 +0200
Message-ID	<sx6Ep-3dL-3@gated-at.bofh.it> (permalink)
References	<suIGg-6Bt-133@gated-at.bofh.it> <suIGj-6Bt-253@gated-at.bofh.it> <swwUi-4ri-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/26/2016 10:56 PM, Lee Jones wrote:
>> diff --git a/include/linux/mfd/tps65217.h b/include/linux/mfd/tps65217.h
>> > index 4ccda89..75a3a5f 100644
>> > --- a/include/linux/mfd/tps65217.h
>> > +++ b/include/linux/mfd/tps65217.h
>> > @@ -235,9 +235,9 @@ struct tps65217_bl_pdata {
>> >  };
>> >
>> >  enum tps65217_irq_type {
>> > -	TPS65217_IRQ_PB,
>> > -	TPS65217_IRQ_AC,
>> >  	TPS65217_IRQ_USB,
>> > +	TPS65217_IRQ_AC,
>> > +	TPS65217_IRQ_PB,
>> >  	TPS65217_NUM_IRQ
>> >  };
> This is why using enum for these types of assignments is sometimes
> dangerous.  It's probably best to be explicit.

I agree with you. Let me fix in v2 - use #define instead of enum type.

Best regards,
Milo

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 7/7] mfd: tps65217: Fix mismatched interrupt number Milo Kim <woogyom.kim@gmail.com> - 2016-10-28 06:10 +0200

csiph-web