Re: [PATCH] clk: xgene: Don't call __pa on ioremaped address

From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: xgene: Don't call __pa on ioremaped address
Date	2016-10-28 01:40 +0200
Message-ID	<sx2r8-9r-19@gated-at.bofh.it> (permalink)
References	<sx2hr-4V-21@gated-at.bofh.it> <sx2hr-4V-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/27, Laura Abbott wrote:
> On 10/27/2016 04:21 PM, Laura Abbott wrote:
> >
> >@@ -269,7 +267,7 @@ static int xgene_clk_enable(struct clk_hw *hw)
> > 		xgene_clk_write(data, pclk->param.csr_reg +
> > 					pclk->param.reg_csr_offset);
> > 		pr_debug("%s CSR RESET PADDR base %pa csr offset 0x%08X mask 0x%08X value 0x%08X\n",
> 
> Bah, this got fixed locally but didn't get amended. I'll remove
> the format here in a v2 assuming there are no other objections.
> 

Include a Fixes: tag too? It would be nice if sparse complained
about __pa used on an __iomem pointer too.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] clk: xgene: Don't call __pa on ioremaped address Laura Abbott <labbott@redhat.com> - 2016-10-28 01:30 +0200
  Re: [PATCH] clk: xgene: Don't call __pa on ioremaped address Stephen Boyd <sboyd@codeaurora.org> - 2016-10-28 01:40 +0200

csiph-web