Re: [PATCH] rtl8xxxu: mark symbol static where possible

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rtl8xxxu: mark symbol static where possible
Date	2016-10-26 18:00 +0200
Message-ID	<swyMq-5PJ-41@gated-at.bofh.it> (permalink)
References	<swsQG-1Lu-43@gated-at.bofh.it> <swvES-3Eq-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Jakub Sitnicki <jkbs@redhat.com>
Date: Wed, 26 Oct 2016 14:37:15 +0200

> On Wed, Oct 26, 2016 at 09:32 AM GMT, Baoyou Xie wrote:
>> We get 1 warning when building kernel with W=1:
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c:1557:6: warning: no previous prototype for 'rtl8192eu_power_off' [-Wmissing-prototypes]
>>
>> In fact, this function is only used in the file in which it is
>> declared and don't need a declaration, but can be made static.
>> So this patch marks this function with 'static'.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>> ---
>>  drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
>> index 883fd98..4d975f0 100644
>> --- a/drivers/net/dsa/mv88e6xxx/chip.c
>> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
>> @@ -2701,7 +2701,7 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port)
>>  	return mv88e6xxx_port_write(chip, port, PORT_DEFAULT_VLAN, 0x0000);
>>  }
>>  
>> -int mv88e6xxx_g1_set_switch_mac(struct mv88e6xxx_chip *chip, u8 *addr)
>> +static int mv88e6xxx_g1_set_switch_mac(struct mv88e6xxx_chip *chip, u8 *addr)
>>  {
>>  	int err;
> 
> Probably a mix-up - your patch doesn't match the description.

Agreed, please fix your subject line and commit message.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rtl8xxxu: mark symbol static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-10-26 11:40 +0200
  Re: [PATCH] rtl8xxxu: mark symbol static where possible Jakub Sitnicki <jkbs@redhat.com> - 2016-10-26 14:40 +0200
    Re: [PATCH] rtl8xxxu: mark symbol static where possible David Miller <davem@davemloft.net> - 2016-10-26 18:00 +0200

csiph-web