Re: [PATCH] KVM: fix OOPS on flush_work

From	Cornelia Huck <cornelia.huck@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] KVM: fix OOPS on flush_work
Date	2016-10-26 14:10 +0200
Message-ID	<swvbQ-3py-31@gated-at.bofh.it> (permalink)
References	<swuSt-32v-3@gated-at.bofh.it>
Organization	IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

Show all headers | View raw

On Wed, 26 Oct 2016 13:44:50 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> The conversion done by commit 3706feacd007 ("KVM: Remove deprecated
> create_singlethread_workqueue") is broken.  It flushes a single work
> item &irqfd->shutdown instead of all of them, and even worse if there
> is no irqfd on the list then you get a NULL pointer dereference.
> Revert the virt/kvm/eventfd.c part of that patch; to avoid the
> deprecated function, just allocate our own workqueue---it does
> not even have to be unbound---with alloc_workqueue.
> 
> Fixes: 3706feacd007
> Cc: stable@vger.kernel.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  virt/kvm/eventfd.c  | 22 +++++++++++++++++++---
>  virt/kvm/kvm_main.c |  6 ++++++
>  2 files changed, 25 insertions(+), 3 deletions(-)

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] KVM: fix OOPS on flush_work Paolo Bonzini <pbonzini@redhat.com> - 2016-10-26 13:50 +0200
  Re: [PATCH] KVM: fix OOPS on flush_work Cornelia Huck <cornelia.huck@de.ibm.com> - 2016-10-26 14:10 +0200

csiph-web