Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1509079
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers |
| Date | 2016-10-26 13:20 +0200 |
| Message-ID | <swups-2Sj-53@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <svP2V-Pj-5@gated-at.bofh.it> <svPmi-ZI-35@gated-at.bofh.it> <svX0t-5XK-9@gated-at.bofh.it> <sw8oV-53d-1@gated-at.bofh.it> <swtD3-2ly-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 26/10/2016 12:23, Wanpeng Li wrote:
>> >
>> > if (apic_lvtt_oneshot(apic) &&
>> > - ktime_after(apic->lapic_timer.target_expiration,
>> > - apic->lapic_timer.timer.base->get_time())) {
>> > + !ktime_after(apic->lapic_timer.target_expiration,
>> > + apic->lapic_timer.timer.base->get_time())) {
>> > apic_timer_expired(apic);
>> > return;
>> > }
>> >
>> > Paolo, can you squash that?
> It seems that squash is impossible since the dependency of current
> kvm/queue(KVM: x86: use ktime_get instead of seeking the
> hrtimer_clock_base), I will send out a separate patch to fix this.
It is squashed in:
+ if (apic_lvtt_oneshot(apic) &&
+ ktime_after(apic->lapic_timer.timer.base->get_time(),
+ apic->lapic_timer.target_expiration)) {
+ apic_timer_expired(apic);
+ return;
+ }
Notice that the order of the arguments is inverted (alternatively I
could have used ktime_before).
Paolo
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/5] KVM: LAPIC: Add APIC Timer periodic/oneshot mode VMX preemption timer support Wanpeng Li <kernellwp@gmail.com> - 2016-10-24 12:30 +0200
[PATCH v3 3/5] KVM: LAPIC: introduce kvm_get_lapic_target_expiration_tsc() Wanpeng Li <kernellwp@gmail.com> - 2016-10-24 12:30 +0200
[PATCH v3 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX preemption timer support Wanpeng Li <kernellwp@gmail.com> - 2016-10-24 12:30 +0200
Re: [PATCH v3 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX preemption timer support Radim Krčmář <rkrcmar@redhat.com> - 2016-10-24 17:00 +0200
Re: [PATCH v3 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX preemption timer support Wanpeng Li <kernellwp@gmail.com> - 2016-10-25 01:40 +0200
[PATCH v3 2/5] KVM: LAPIC: guarantee the timer is in tsc-deadline mode Wanpeng Li <kernellwp@gmail.com> - 2016-10-24 12:30 +0200
Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Paolo Bonzini <pbonzini@redhat.com> - 2016-10-24 17:10 +0200
Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Radim Krčmář <rkrcmar@redhat.com> - 2016-10-24 17:30 +0200
Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Wanpeng Li <kernellwp@gmail.com> - 2016-10-25 01:40 +0200
Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Radim Krčmář <rkrcmar@redhat.com> - 2016-10-25 13:50 +0200
Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Paolo Bonzini <pbonzini@redhat.com> - 2016-10-25 14:00 +0200
Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Wanpeng Li <kernellwp@gmail.com> - 2016-10-26 08:10 +0200
Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Wanpeng Li <kernellwp@gmail.com> - 2016-10-26 08:10 +0200
Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Radim Krčmář <rkrcmar@redhat.com> - 2016-10-26 16:10 +0200
Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Radim Krčmář <rkrcmar@redhat.com> - 2016-10-26 15:40 +0200
Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Wanpeng Li <kernellwp@gmail.com> - 2016-10-26 12:30 +0200
Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Paolo Bonzini <pbonzini@redhat.com> - 2016-10-26 13:20 +0200
Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Wanpeng Li <kernellwp@gmail.com> - 2016-10-26 13:30 +0200
[PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Radim Krčmář <rkrcmar@redhat.com> - 2016-10-24 17:10 +0200
Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers Radim Krčmář <rkrcmar@redhat.com> - 2016-10-25 15:10 +0200
csiph-web