Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1509032

Re: [PATCH 3/3] x86/vmware: Add paravirt sched clock

Show all headers | View raw

On Tue, 25 Oct 2016, Alexey Makhalov wrote:
> no-vmw-sched-clock kernel parameter is added to switch back to the
> native_sched_clock() implementation.

You are not switching back. The parameter is used to disable the paravirt
sched clock.

>  #ifdef CONFIG_PARAVIRT
> +static struct cyc2ns_data vmware_cyc2ns __ro_after_init;
> +
> +static int vmw_sched_clock __initdata = 1;
> +static __init int setup_vmw_sched_clock(char *s)

Please stop glueing a variable to a function w/o a new line between
them. It's just stopping the reading flow.

> +{
> +	vmw_sched_clock = 0;
> +	return 0;
> +}
> +early_param("no-vmw-sched-clock", setup_vmw_sched_clock);
> +
> +static unsigned long long vmware_sched_clock(void)
> +{
> +	unsigned long long ns;
> +
> +	ns = mul_u64_u32_shr(rdtsc(), vmware_cyc2ns.cyc2ns_mul,
> +			     vmware_cyc2ns.cyc2ns_shift);
> +	ns -= vmware_cyc2ns.cyc2ns_offset;
> +	return ns;
> +}
> +
>  static void __init vmware_paravirt_ops_setup(void)
>  {
>  	pv_info.name = "VMware";
>  	pv_cpu_ops.io_delay = paravirt_nop;
> +
> +	if (vmware_tsc_khz && vmw_sched_clock) {
> +		unsigned long long tsc_now = rdtsc();
> +
> +		clocks_calc_mult_shift(&vmware_cyc2ns.cyc2ns_mul,
> +				       &vmware_cyc2ns.cyc2ns_shift,
> +				       vmware_tsc_khz,
> +				       NSEC_PER_MSEC, 0);
> +		vmware_cyc2ns.cyc2ns_offset =
> +			mul_u64_u32_shr(tsc_now, vmware_cyc2ns.cyc2ns_mul,
> +					vmware_cyc2ns.cyc2ns_shift);
> +
> +		pv_time_ops.sched_clock = vmware_sched_clock;
> +		pr_info("vmware: using sched offset of %llu ns\n",

Please use pr_fmt instead of adding the prefix to every print.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] x86/vmware guest improvements Alexey Makhalov <amakhalov@vmware.com> - 2016-10-26 07:30 +0200
  [PATCH 2/3] x86/vmware: Add basic paravirt ops support Alexey Makhalov <amakhalov@vmware.com> - 2016-10-26 07:30 +0200
    Re: [PATCH 2/3] x86/vmware: Add basic paravirt ops support Tim Mann <mann@vmware.com> - 2016-10-26 22:50 +0200
      Re: [PATCH 2/3] x86/vmware: Add basic paravirt ops support Thomas Gleixner <tglx@linutronix.de> - 2016-10-26 23:00 +0200
  [PATCH 1/3] x86/vmware: Use tsc_khz value for calibrate_cpu() Alexey Makhalov <amakhalov@vmware.com> - 2016-10-26 07:30 +0200
  [PATCH 3/3] x86/vmware: Add paravirt sched clock Alexey Makhalov <amakhalov@vmware.com> - 2016-10-26 07:30 +0200
    Re: [PATCH 3/3] x86/vmware: Add paravirt sched clock Thomas Gleixner <tglx@linutronix.de> - 2016-10-26 12:30 +0200
      [PATCH v2 3/3] x86/vmware: Add paravirt sched clock Alexey Makhalov <amakhalov@vmware.com> - 2016-10-26 19:00 +0200

csiph-web