Re: [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify ACPI support code.

From	Fu Wei <fu.wei@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify ACPI support code.
Date	2016-10-26 11:10 +0200
Message-ID	<swsnD-1Bb-5@gated-at.bofh.it> (permalink)
References	<smrCx-1LD-3@gated-at.bofh.it> <smrCy-1LD-19@gated-at.bofh.it> <suoRc-1Jo-7@gated-at.bofh.it> <suG1I-4Ml-7@gated-at.bofh.it> <suGbo-4PN-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Mark,

On 21 October 2016 at 19:21, Mark Rutland <mark.rutland@arm.com> wrote:
> On Fri, Oct 21, 2016 at 12:14:01PM +0100, Mark Rutland wrote:
>> On Thu, Oct 20, 2016 at 05:58:17PM +0100, Mark Rutland wrote:
>> > On Thu, Sep 29, 2016 at 02:17:13AM +0800, fu.wei@linaro.org wrote:
>> > > + arch_timer_ppi[PHYS_NONSECURE_PPI] = acpi_gtdt_map_ppi(PHYS_NONSECURE_PPI);
>> > > + arch_timer_ppi[VIRT_PPI] = acpi_gtdt_map_ppi(VIRT_PPI);
>> > > + arch_timer_ppi[HYP_PPI] = acpi_gtdt_map_ppi(HYP_PPI);
>> > > + /* Always-on capability */
>> > > + arch_timer_c3stop = acpi_gtdt_c3stop();
>> >
>> > ... I think we should check the flag on the relevant interrupt, though
>> > that's worth clarifying.
>>
>> I see I misread the spec; this is part of the common flags.
>>
>> Please ignore this point; sorry for the noise.
>
> Actually, I misread the spec this time around; the flag *can* differ per
> interrupt for the sysreg/cp15 timer, but not for the MMIO timers where
> the flag is in a common field.
>
> So please *do* consider the above.

yes , you are right , will do
Thanks :-)

>
> Thanks,
> Mark.



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify  ACPI support code. Mark Rutland <mark.rutland@arm.com> - 2016-10-20 19:00 +0200
  Re: [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify  ACPI support code. Mark Rutland <mark.rutland@arm.com> - 2016-10-21 13:20 +0200
    Re: [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify  ACPI support code. Mark Rutland <mark.rutland@arm.com> - 2016-10-21 13:30 +0200
      Re: [PATCH v14 5/9] clocksource/drivers/arm_arch_timer: Simplify ACPI  support code. Fu Wei <fu.wei@linaro.org> - 2016-10-26 11:10 +0200

csiph-web