Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1508946

Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration.

Show all headers | View raw

On Tuesday 25 October 2016 09:23 PM, David Lechner wrote:
> Hi Sekhar,
> 
> On 10/25/2016 05:17 AM, Sekhar Nori wrote:
>> On Tuesday 25 October 2016 03:07 PM, Axel Haslam wrote:
>>> Hi Sekar,
>>>
>>> On Tue, Oct 25, 2016 at 10:10 AM, Sekhar Nori <nsekhar@ti.com> wrote:
>>>> On Monday 24 October 2016 10:16 PM, ahaslam@baylibre.com wrote:
>>>>> From: David Lechner <david@lechnology.com>
>>>>>
>>>>> The CFGCHIP registers are used by a number of devices, so using a
>>>>> syscon
>>>>> device to share them. The first consumer of this will by the
>>>>> phy-da8xx-usb
>>>>> driver.
>>>>>
>>>>> Signed-off-by: David Lechner <david@lechnology.com>
>>>>> [Axel: minor fix: change id to -1]
>>>>
>>>> Can you please clarify this change? There could be other syscon devices
>>>> on the chip for other common registers. Why use the singular device-id?
>>>>
>>>
>>> in the case of non DT boot, the phy driver is looking for "syscon" :
>>>
>>> d_phy->regmap = syscon_regmap_lookup_by_pdevname("syscon");
>>>
>>> if we register the syscon driver with id = 0, the actual name of the
>>> syscon
>>> device will be "syscon.0" and the phy driver will fail to probe, because
>>> the strncmp match in the syscon driver (syscon_match_pdevname)
>>> will fail.
>>>
>>> should i change the phy driver instead?
>>
>> Yes, please. Forcing only one syscon region for the whole chip will be
>> too restrictive, I am pretty sure.
>>
>> Thanks,
>> Sekhar
>>
> 
> In the previous review, you requested that this be changed to -1 [1].
> 
> If we change it back to 0, it will also require reverting a patch to the
> phy driver that has already been merged[2].

Sigh. Sorry about going around in circles on this one. Lets go with what
you have. If and when there is a need for another syscon node, the
driver and platform code can be updated. At least we will know why the
change is being done at that time.

Thanks,
Sekhar

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH/RFT v2 00/17] Add DT support for ohci-da8xx ahaslam@baylibre.com - 2016-10-24 18:50 +0200
  [PATCH/RFT v2 01/17] ARM: davinci: da8xx: add usb phy clocks ahaslam@baylibre.com - 2016-10-24 18:50 +0200
  [PATCH/RFT v2 15/17] usb: host: ohci-da8xx: Add devicetree bindings documentation ahaslam@baylibre.com - 2016-10-24 18:50 +0200
    Re: [PATCH/RFT v2 15/17] usb: host: ohci-da8xx: Add devicetree  bindings documentation David Lechner <david@lechnology.com> - 2016-10-25 03:10 +0200
      Re: [PATCH/RFT v2 15/17] usb: host: ohci-da8xx: Add devicetree  bindings documentation Axel Haslam <ahaslam@baylibre.com> - 2016-10-25 12:00 +0200
  [PATCH/RFT v2 07/17] ARM: davinci: da8xx: Enable the usb20 "per" clk on phy_clk_enable ahaslam@baylibre.com - 2016-10-24 18:50 +0200
    Re: [PATCH/RFT v2 07/17] ARM: davinci: da8xx: Enable the usb20 "per"  clk on phy_clk_enable David Lechner <david@lechnology.com> - 2016-10-25 05:00 +0200
      Re: [PATCH/RFT v2 07/17] ARM: davinci: da8xx: Enable the usb20 "per"  clk on phy_clk_enable Axel Haslam <ahaslam@baylibre.com> - 2016-10-25 12:10 +0200
    Re: [PATCH/RFT v2 07/17] ARM: davinci: da8xx: Enable the usb20 "per"  clk on phy_clk_enable Sekhar Nori <nsekhar@ti.com> - 2016-10-25 12:20 +0200
      Re: [PATCH/RFT v2 07/17] ARM: davinci: da8xx: Enable the usb20 "per"  clk on phy_clk_enable David Lechner <david@lechnology.com> - 2016-10-25 18:10 +0200
        Re: [PATCH/RFT v2 07/17] ARM: davinci: da8xx: Enable the usb20 "per"  clk on phy_clk_enable Sekhar Nori <nsekhar@ti.com> - 2016-10-26 11:40 +0200
  [PATCH/RFT v2 10/17] USB: da8xx: use flag instead of bitmask for over current change ahaslam@baylibre.com - 2016-10-24 18:50 +0200
  [PATCH/RFT v2 16/17] USB: ohci-da8xx: Allow probing from DT ahaslam@baylibre.com - 2016-10-24 18:50 +0200
    Re: [PATCH/RFT v2 16/17] USB: ohci-da8xx: Allow probing from DT David Lechner <david@lechnology.com> - 2016-10-25 03:00 +0200
      Re: [PATCH/RFT v2 16/17] USB: ohci-da8xx: Allow probing from DT Axel Haslam <ahaslam@baylibre.com> - 2016-10-25 10:20 +0200
  [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration. ahaslam@baylibre.com - 2016-10-24 18:50 +0200
    Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon  platform declaration. Sekhar Nori <nsekhar@ti.com> - 2016-10-25 10:20 +0200
      Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon  platform declaration. Axel Haslam <ahaslam@baylibre.com> - 2016-10-25 11:40 +0200
        Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon  platform declaration. Sekhar Nori <nsekhar@ti.com> - 2016-10-25 12:20 +0200
          Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon  platform declaration. David Lechner <david@lechnology.com> - 2016-10-25 18:00 +0200
            Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon  platform declaration. Sekhar Nori <nsekhar@ti.com> - 2016-10-26 11:00 +0200
  [PATCH/RFT v2 04/17] ARM: DTS: da850: Add cfgchip syscon node ahaslam@baylibre.com - 2016-10-24 19:00 +0200
  [PATCH/RFT v2 03/17] ARM: davinci: da8xx: Add USB PHY platform declaration ahaslam@baylibre.com - 2016-10-24 19:00 +0200
    Re: [PATCH/RFT v2 03/17] ARM: davinci: da8xx: Add USB PHY platform  declaration Sekhar Nori <nsekhar@ti.com> - 2016-10-25 11:20 +0200
      Re: [PATCH/RFT v2 03/17] ARM: davinci: da8xx: Add USB PHY platform declaration Axel Haslam <ahaslam@baylibre.com> - 2016-10-25 11:40 +0200
  [PATCH/RFT v2 08/17] ARM: davinci: hawk: add full constraints for ohci plat boot ahaslam@baylibre.com - 2016-10-24 19:00 +0200
    Re: [PATCH/RFT v2 08/17] ARM: davinci: hawk: add full constraints for  ohci plat boot Sekhar Nori <nsekhar@ti.com> - 2016-10-25 12:40 +0200
      Re: [PATCH/RFT v2 08/17] ARM: davinci: hawk: add full constraints for  ohci plat boot Axel Haslam <ahaslam@baylibre.com> - 2016-10-25 12:40 +0200
  [PATCH/RFT v2 06/17] ARM: davinci: da8xx: Fix some redefined symbol warnings ahaslam@baylibre.com - 2016-10-24 19:00 +0200
    Re: [PATCH/RFT v2 06/17] ARM: davinci: da8xx: Fix some redefined  symbol warnings Sekhar Nori <nsekhar@ti.com> - 2016-10-25 12:10 +0200
      Re: [PATCH/RFT v2 06/17] ARM: davinci: da8xx: Fix some redefined  symbol warnings Alexandre Bailon <abailon@baylibre.com> - 2016-10-25 14:20 +0200
  [PATCH/RFT v2 05/17] ARM: DTS: da850: Add usb phy node ahaslam@baylibre.com - 2016-10-24 19:00 +0200
  Re: [PATCH/RFT v2 00/17] Add DT support for ohci-da8xx Sekhar Nori <nsekhar@ti.com> - 2016-10-25 13:00 +0200

csiph-web