Re: [PATCH] arm64: Neaten show_regs, remove KERN_CONT

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64: Neaten show_regs, remove KERN_CONT
Date	2016-10-25 20:10 +0200
Message-ID	<swekG-GE-43@gated-at.bofh.it> (permalink)
References	<svxSq-5JC-9@gated-at.bofh.it> <svLLI-6ZR-19@gated-at.bofh.it> <svQin-1Di-71@gated-at.bofh.it> <svQBH-1Ks-31@gated-at.bofh.it> <swdRE-fJ-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Oct 25, 2016 at 10:38:31AM -0700, Linus Torvalds wrote:
> On Mon, Oct 24, 2016 at 9:42 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> >
> > That does not appear to be the case; as fr as I can tell the core prints a
> > timestamp per line as required. If I run:
> >
> >         printk("TEST\nLINE1\nLINE2\nLINE3\nLINE4\n");
> 
> Please don't do this.
>
> It has historically not worked well, and it still doesn't actually
> work reliably. In particular, it currently works in the *logs* (ie
> dmesg), but not necessarily on screen (because "msg_print_text()" does
> do the "look for newlines in the middle", but console_cont_flush()
> does not).

Sure; I'll avoid that.

it seems that's a drop in the ocean, though. :/

[mark@leverpostej:~/src/linux]% git grep 'pr\(intk\|_.*\)(.*)' | grep '\\n[^"]' | wc -l 
375

> So you can try the attached patch. It likely fixes your issues simply
> because it removes all the crazy code.

That worked for me. I see consistent results over the UART and in dmesg
with that applied atop of v4.9-rc2. Feel free to add:

Tested-by: Mark Rutland <mark.rutland@arm.com>

Thanks,
Mark.

Thread

[PATCH] arm64: Neaten show_regs, remove KERN_CONT Joe Perches <joe@perches.com> - 2016-10-23 22:50 +0200
  Re: [PATCH] arm64: Neaten show_regs, remove KERN_CONT Mark Rutland <mark.rutland@arm.com> - 2016-10-24 13:40 +0200
    Re: [PATCH] arm64: Neaten show_regs, remove KERN_CONT Joe Perches <joe@perches.com> - 2016-10-24 18:30 +0200
      Re: [PATCH] arm64: Neaten show_regs, remove KERN_CONT Mark Rutland <mark.rutland@arm.com> - 2016-10-24 18:50 +0200
        Re: [PATCH] arm64: Neaten show_regs, remove KERN_CONT Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-25 19:40 +0200
          Re: [PATCH] arm64: Neaten show_regs, remove KERN_CONT Linus Torvalds <torvalds@linux-foundation.org> - 2016-10-25 20:00 +0200
            Re: [PATCH] arm64: Neaten show_regs, remove KERN_CONT Joe Perches <joe@perches.com> - 2016-10-25 20:10 +0200
          Re: [PATCH] arm64: Neaten show_regs, remove KERN_CONT Mark Rutland <mark.rutland@arm.com> - 2016-10-25 20:10 +0200
      Re: [PATCH] arm64: Neaten show_regs, remove KERN_CONT Mark Rutland <mark.rutland@arm.com> - 2016-10-25 16:40 +0200
        Re: [PATCH] arm64: Neaten show_regs, remove KERN_CONT Joe Perches <joe@perches.com> - 2016-10-25 18:50 +0200

csiph-web