Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1508529

Re: [RFC v3 1/6] Track the active utilisation

Show all headers | View raw

On Tue, 25 Oct 2016 09:58:11 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 25 Oct 2016 11:29:16 +0200
> luca abeni <luca.abeni@unitn.it> wrote:
> 
> > Hi Daniel,
> > 
> > On Tue, 25 Oct 2016 11:09:52 +0200
> > Daniel Bristot de Oliveira <bristot@redhat.com> wrote:
> > [...]
> > > > +static void add_running_bw(struct sched_dl_entity *dl_se,
> > > > struct dl_rq *dl_rq) +{
> > > > +	u64 se_bw = dl_se->dl_bw;
> > > > +
> > > > +	dl_rq->running_bw += se_bw;
> > > > +}    
> > > 
> > > why not...
> > > 
> > > static *inline*
> > > void add_running_bw(struct sched_dl_entity *dl_se, struct dl_rq
> > > *dl_rq) {
> > > 	dl_rq->running_bw += dl_se->dl_bw;
> > > }
> > > 
> > > am I missing something?  
> > 
> > I do not know... Maybe I am the one missing something :)
> > I assumed that the compiler is smart enough to inline the function
> > (and to avoid creating a local variable on the stack), but if there
> > is agreement I can change the function in this way.
> > 
> > 
> 
> I agree with Daniel, especially since I don't usually trust the
> compiler. And the added variable is more of a distraction as it
> doesn't seem to have any real purpose.

Ok, then; I'll fix this in the next round of patches.


		Thanks,
			Luca

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC v3 0/6] CPU reclaiming for SCHED_DEADLINE  Luca Abeni <luca.abeni@unitn.it> - 2016-10-24 16:10 +0200
  [RFC v3 5/6] Do not reclaim the whole CPU bandwidth Luca Abeni <luca.abeni@unitn.it> - 2016-10-24 16:10 +0200
  [RFC v3 1/6] Track the active utilisation Luca Abeni <luca.abeni@unitn.it> - 2016-10-24 16:10 +0200
    Re: [RFC v3 1/6] Track the active utilisation Daniel Bristot de Oliveira <bristot@redhat.com> - 2016-10-25 11:20 +0200
      Re: [RFC v3 1/6] Track the active utilisation luca abeni <luca.abeni@unitn.it> - 2016-10-25 11:30 +0200
        Re: [RFC v3 1/6] Track the active utilisation Steven Rostedt <rostedt@goodmis.org> - 2016-10-25 16:00 +0200
          Re: [RFC v3 1/6] Track the active utilisation Luca Abeni <luca.abeni@unitn.it> - 2016-10-25 20:10 +0200
  [RFC v3 2/6] Improve the tracking of active utilisation Luca Abeni <luca.abeni@unitn.it> - 2016-10-24 16:10 +0200
  [RFC v3 3/6] Fix the update of the total -deadline utilization Luca Abeni <luca.abeni@unitn.it> - 2016-10-24 16:10 +0200
  [RFC v3 4/6] GRUB accounting Luca Abeni <luca.abeni@unitn.it> - 2016-10-24 16:10 +0200

csiph-web