Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query

From	Matt Ranostay <mranostay@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query
Date	2016-10-25 20:50 +0200
Message-ID	<sweXo-W6-17@gated-at.bofh.it> (permalink)
References	<smtbj-2Ad-15@gated-at.bofh.it> <smtbj-2Ad-13@gated-at.bofh.it> <svTzz-3Fg-1@gated-at.bofh.it> <svTSW-43c-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 24, 2016 at 1:14 PM, Pavel Machek <pavel@ucw.cz> wrote:
> On Mon 2016-10-24 12:58:25, Matt Ranostay wrote:
>> Pavel + Sebastian this is the patchset that need I some input on :)
>
> Better then previous one.
>
> But my version of bq27xxx_battery.c already contains this:

This is for allowing udev rule to set the properties as well.
otherwise a kinda crude RUN = " echo value >
/sys/module/bq27xxx_battery/parameters/poll_interval" is required.

>
> static const struct kernel_param_ops param_ops_poll_interval = {
>         .get = param_get_uint,
>         .set = poll_interval_param_set,
> };
>
> ...so it should be possible to set poll interval already.
>
>                                                                         Pavel
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Matt Ranostay <mranostay@gmail.com> - 2016-10-24 22:00 +0200
  Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval  property query Pavel Machek <pavel@ucw.cz> - 2016-10-24 22:20 +0200
    Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Matt Ranostay <mranostay@gmail.com> - 2016-10-25 20:50 +0200

csiph-web