Re: [PATCH v3 1/1] kthread: allocate kthread structure using kmalloc

From	Andy Lutomirski <luto@amacapital.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/1] kthread: allocate kthread structure using kmalloc
Date	2016-10-25 19:00 +0200
Message-ID	<swdeW-8ec-11@gated-at.bofh.it> (permalink)
References	<sw7Md-4N9-1@gated-at.bofh.it> <swaAq-6ET-17@gated-at.bofh.it> <swc9c-7vM-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Oct 25, 2016 at 8:43 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> On 10/25, Oleg Nesterov wrote:
>>
>> On 10/25, Roman Pen wrote:
>> >
>> > This patch avoids allocation of kthread structure on a stack, and simply
>> > uses kmalloc.
>>
>> Oh. I didn't even read this patch, but I have to admit I personally do not
>> like it. I can be wrong, but imo this is the step to the wrong direction.
>
> And after I tried to actually read it I dislike it even more, sorry Roman.
> Starting from the fact it moves kthread_create_info into struct kthread.

Would it perhaps make sense to do something like Roman's patch for 4.9
and then consider further changes down the road?  Roman's patch
appears to fix a real bug, and I think that, while not really ideal,
the code is an incredible mess right now and Roman's patch (assuming
it's correct) makes it considerably nicer.

Thread

[PATCH v3 1/1] kthread: allocate kthread structure using kmalloc Roman Pen <roman.penyaev@profitbricks.com> - 2016-10-25 13:10 +0200
  Re: [PATCH v3 1/1] kthread: allocate kthread structure using         kmalloc Oleg Nesterov <oleg@redhat.com> - 2016-10-25 16:10 +0200
    Re: [PATCH v3 1/1] kthread: allocate kthread structure using kmalloc Roman Penyaev <roman.penyaev@profitbricks.com> - 2016-10-25 17:50 +0200
    Re: [PATCH v3 1/1] kthread: allocate kthread structure using         kmalloc Oleg Nesterov <oleg@redhat.com> - 2016-10-25 17:50 +0200
      Re: [PATCH v3 1/1] kthread: allocate kthread structure using         kmalloc Oleg Nesterov <oleg@redhat.com> - 2016-10-25 18:20 +0200
      Re: [PATCH v3 1/1] kthread: allocate kthread structure using kmalloc Roman Penyaev <roman.penyaev@profitbricks.com> - 2016-10-25 18:20 +0200
      Re: [PATCH v3 1/1] kthread: allocate kthread structure using kmalloc Andy Lutomirski <luto@amacapital.net> - 2016-10-25 19:00 +0200
        Re: [PATCH v3 1/1] kthread: allocate kthread structure using kmalloc Oleg Nesterov <oleg@redhat.com> - 2016-10-26 16:20 +0200
          Re: [PATCH v3 1/1] kthread: allocate kthread structure using  kmalloc Thomas Gleixner <tglx@linutronix.de> - 2016-10-26 17:10 +0200
            Re: [PATCH v3 1/1] kthread: allocate kthread structure using         kmalloc Oleg Nesterov <oleg@redhat.com> - 2016-10-26 18:00 +0200
              Re: [PATCH v3 1/1] kthread: allocate kthread structure using  kmalloc Thomas Gleixner <tglx@linutronix.de> - 2016-10-26 20:40 +0200
          Re: [PATCH v3 1/1] kthread: allocate kthread structure using         kmalloc Oleg Nesterov <oleg@redhat.com> - 2016-10-26 18:20 +0200

csiph-web