Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1508405

Re: [PATCH v3 1/1] workqueue: ignore dead tasks in a workqueue sleep hook

Show all headers | View raw

sorry for noise, forgot to mention...

On 10/25, Oleg Nesterov wrote:
>
> On 10/25, Oleg Nesterov wrote:
> >
> > 	void oops_end_exit(void)
> > 	{
> > 		current->flags &= ~PF_WQ_WORKER;
> > 		perhaps sonething else;
> > 	}
> >
> > called by oops_end() before rewind_stack_do_exit() ?
>
> and "perhaps sonething else" above should probably clear current->plug,
> it likely points to "struct blk_plug" on stack.
>
> and perhaps call task_work_run(). Currently only irq_thread() uses the
> "destructor" work on stack, but think can have more users.

and, probably absorb some code from do_exit(), say set_fs(USER_DS) and/or
PF_EXITING check.

Oleg.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/1] workqueue: ignore dead tasks in a workqueue sleep hook Roman Pen <roman.penyaev@profitbricks.com> - 2016-10-25 13:10 +0200
  Re: [PATCH v3 1/1] workqueue: ignore dead tasks in a workqueue         sleep hook Oleg Nesterov <oleg@redhat.com> - 2016-10-25 15:00 +0200
    Re: [PATCH v3 1/1] workqueue: ignore dead tasks in a workqueue sleep hook Roman Penyaev <roman.penyaev@profitbricks.com> - 2016-10-25 15:10 +0200
      Re: [PATCH v3 1/1] workqueue: ignore dead tasks in a workqueue         sleep hook Oleg Nesterov <oleg@redhat.com> - 2016-10-25 16:30 +0200
        Re: [PATCH v3 1/1] workqueue: ignore dead tasks in a workqueue         sleep hook Oleg Nesterov <oleg@redhat.com> - 2016-10-25 18:00 +0200
          Re: [PATCH v3 1/1] workqueue: ignore dead tasks in a workqueue         sleep hook Oleg Nesterov <oleg@redhat.com> - 2016-10-25 18:10 +0200
            Re: [PATCH v3 1/1] workqueue: ignore dead tasks in a workqueue sleep hook Roman Penyaev <roman.penyaev@profitbricks.com> - 2016-10-25 20:20 +0200

csiph-web