Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1508441

[tip:x86/microcode] x86/microcode: Issue the debug printk on resume only on success

Show all headers | View raw

Commit-ID:  6b14b81899a2e1e5dd0d089f2a41a6118929658d
Gitweb:     http://git.kernel.org/tip/6b14b81899a2e1e5dd0d089f2a41a6118929658d
Author:     Borislav Petkov <bp@suse.de>
AuthorDate: Tue, 25 Oct 2016 11:55:17 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 25 Oct 2016 12:28:58 +0200

x86/microcode: Issue the debug printk on resume only on success

Move it after the patch application function which also checks whether
we were successful.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20161025095522.11964-8-bp@alien8.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/cpu/microcode/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
index b67145d..a18ff75 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -460,11 +460,11 @@ static void microcode_fini_cpu(int cpu)
 
 static enum ucode_state microcode_resume_cpu(int cpu)
 {
-	pr_debug("CPU%d updated upon resume\n", cpu);
-
 	if (apply_microcode_on_target(cpu))
 		return UCODE_ERROR;
 
+	pr_debug("CPU%d updated upon resume\n", cpu);
+
 	return UCODE_OK;
 }
 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/12] x86/microcode: Rework microcode loading Borislav Petkov <bp@alien8.de> - 2016-10-25 12:00 +0200
  [PATCH 07/12] x86/microcode: Issue the debug printk on resume only on success Borislav Petkov <bp@alien8.de> - 2016-10-25 12:00 +0200
    [tip:x86/microcode] x86/microcode: Issue the debug printk on resume  only on success tip-bot for Borislav Petkov <tipbot@zytor.com> - 2016-10-25 18:40 +0200
  [PATCH 01/12] x86/microcode: Run the AP-loading routine only on the application processors Borislav Petkov <bp@alien8.de> - 2016-10-25 12:00 +0200
    [tip:x86/microcode] x86/microcode: Run the AP-loading routine only  on the application processors tip-bot for Borislav Petkov <tipbot@zytor.com> - 2016-10-25 18:30 +0200
  [PATCH 09/12] x86/microcode/AMD: Retract functions Borislav Petkov <bp@alien8.de> - 2016-10-25 12:00 +0200
    [tip:x86/microcode] x86/microcode/amd: Move private inlines to .c  and mark local functions static tip-bot for Borislav Petkov <tipbot@zytor.com> - 2016-10-25 18:40 +0200
  [PATCH 08/12] x86/microcode: Collect CPU info on resume Borislav Petkov <bp@alien8.de> - 2016-10-25 12:00 +0200
    [tip:x86/microcode] x86/microcode: Collect CPU info on resume tip-bot for Borislav Petkov <tipbot@zytor.com> - 2016-10-25 18:40 +0200
  [PATCH 10/12] x86/microcode/intel: Remove intel_lib.c Borislav Petkov <bp@alien8.de> - 2016-10-25 12:00 +0200
    [tip:x86/microcode] x86/microcode/intel: Remove intel_lib.c tip-bot for Borislav Petkov <tipbot@zytor.com> - 2016-10-25 18:40 +0200
  [PATCH 06/12] x86/microcode/AMD: Hand down the CPU family Borislav Petkov <bp@alien8.de> - 2016-10-25 12:00 +0200
    [tip:x86/microcode] x86/microcode/amd: Hand down the CPU family tip-bot for Borislav Petkov <tipbot@zytor.com> - 2016-10-25 18:40 +0200
  [PATCH 02/12] x86/microcode: Move driver authors to CREDITS Borislav Petkov <bp@alien8.de> - 2016-10-25 12:00 +0200
    [tip:x86/microcode] x86/microcode: Move driver authors to CREDITS tip-bot for Borislav Petkov <tipbot@zytor.com> - 2016-10-25 18:40 +0200

csiph-web