[PATCH] PM / Domains: check for negative return from of_count_phandle_with_args

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] PM / Domains: check for negative return from of_count_phandle_with_args
Date	2016-10-25 18:40 +0200
Message-ID	<swcVA-86H-19@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The return from of_count_phandle_with_args can be negative, so we
should avoid kcalloc of a negative count of genpd_power_stat structs
by sanity checking if count is zero or less.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/base/power/domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index aac656a..661737c 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -2113,7 +2113,7 @@ int of_genpd_parse_idle_states(struct device_node *dn,
 	struct of_phandle_iterator it;
 
 	count = of_count_phandle_with_args(dn, "domain-idle-states", NULL);
-	if (!count)
+	if (count <= 0)
 		return -EINVAL;
 
 	st = kcalloc(count, sizeof(*st), GFP_KERNEL);
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] PM / Domains: check for negative return from of_count_phandle_with_args Colin King <colin.king@canonical.com> - 2016-10-25 18:40 +0200
  Re: [PATCH] PM / Domains: check for negative return from of_count_phandle_with_args Kevin Hilman <khilman@baylibre.com> - 2016-10-25 20:20 +0200
    Re: [PATCH] PM / Domains: check for negative return from  of_count_phandle_with_args Pavel Machek <pavel@ucw.cz> - 2016-10-26 13:10 +0200

csiph-web