Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event

From	Axel Haslam <ahaslam@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event
Date	2016-10-25 17:10 +0200
Message-ID	<swbwt-7hI-33@gated-at.bofh.it> (permalink)
References	(3 earlier) <svS0N-2QU-13@gated-at.bofh.it> <svSau-2UD-37@gated-at.bofh.it> <sw9uG-5Lw-9@gated-at.bofh.it> <swb3s-6RL-33@gated-at.bofh.it> <swbmO-6YY-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Oct 25, 2016 at 4:57 PM, Axel Haslam <ahaslam@baylibre.com> wrote:
> On Tue, Oct 25, 2016 at 4:33 PM, Mark Brown <broonie@kernel.org> wrote:
>> On Tue, Oct 25, 2016 at 02:55:48PM +0200, Axel Haslam wrote:
>>
>>> To be able to use regulator to handle the overcurrent pin, i need to be able
>>> to somehow retrieve the over current pin state from the regulator driver.
>>
>> What makes you say that, none of the existing users need this?
>>
>>> As i was trying your suggestion, i remembered why i thought i should use
>>> mode instead of status: Status seems to be for internal regulator driver use,
>>> there is no regulator_get_status, function and REGULATOR_STATUS_* are defined
>>> in driver.h and not in consumer.h as  REGULATOR_MODE_*
>>
>>> Would you be ok if i allow consumers to get the status via a new
>>> "regulator_get_status" call?
>>
>> What would they do with this information that they can't do with the
>> existing error notification?
>
> the usb core relies in two flags that need too be set properly, one is the
> over-current indicator RH_PS_POCI , and the other is the over current
> indicator "change" (RH_PS_OCIC).
>
> The idea was to use the notification to set the over current indicator
> "change" flag,
> which will happen for both rising and falling edges. And to use
> get_status or get_mode
> to set the over-current indicator flag which should reflect the actual
> pin status.
>

BTW, for the notification, i should have used a new event flag
something like: OVER_CURRENT_CHANGED and not just OVER_CURRENT


Regards
Axel

>
> -Axel.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH/RFT v2 09/17] regulator: fixed: Add over current event ahaslam@baylibre.com - 2016-10-24 18:50 +0200
  Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event Mark Brown <broonie@kernel.org> - 2016-10-24 19:50 +0200
    Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event Axel Haslam <ahaslam@baylibre.com> - 2016-10-24 20:00 +0200
  Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event Mark Brown <broonie@kernel.org> - 2016-10-24 20:00 +0200
    Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event Axel Haslam <ahaslam@baylibre.com> - 2016-10-24 20:20 +0200
      Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event Mark Brown <broonie@kernel.org> - 2016-10-24 20:30 +0200
        Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event Axel Haslam <ahaslam@baylibre.com> - 2016-10-25 15:00 +0200
          Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event Mark Brown <broonie@kernel.org> - 2016-10-25 16:40 +0200
            Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event Axel Haslam <ahaslam@baylibre.com> - 2016-10-25 17:00 +0200
              Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event Axel Haslam <ahaslam@baylibre.com> - 2016-10-25 17:10 +0200

csiph-web