Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1508371

[PATCH v3 04/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_prepare()

Show all headers | View raw

From: Hanjun Guo <hanjun.guo@linaro.org>

Adding ACPI support for platform MSI, we need to retrieve the
dev id in ACPI way instead of device tree, we already have
a well formed function its_pmsi_prepare() to get the dev id
but it's OF dependent, so collect OF related code and put them
into a single function to make its_pmsi_prepare() more friendly
to ACPI later.

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
Tested-by: Sinan Kaya <okaya@codeaurora.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Tomasz Nowicki <tn@semihalf.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/irqchip/irq-gic-v3-its-platform-msi.c | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/drivers/irqchip/irq-gic-v3-its-platform-msi.c b/drivers/irqchip/irq-gic-v3-its-platform-msi.c
index 470b4aa..3c94278 100644
--- a/drivers/irqchip/irq-gic-v3-its-platform-msi.c
+++ b/drivers/irqchip/irq-gic-v3-its-platform-msi.c
@@ -24,15 +24,11 @@
 	.name			= "ITS-pMSI",
 };
 
-static int its_pmsi_prepare(struct irq_domain *domain, struct device *dev,
-			    int nvec, msi_alloc_info_t *info)
+static int of_pmsi_get_dev_id(struct irq_domain *domain, struct device *dev,
+				  u32 *dev_id)
 {
-	struct msi_domain_info *msi_info;
-	u32 dev_id;
 	int ret, index = 0;
 
-	msi_info = msi_get_domain_info(domain->parent);
-
 	/* Suck the DeviceID out of the msi-parent property */
 	do {
 		struct of_phandle_args args;
@@ -43,11 +39,24 @@ static int its_pmsi_prepare(struct irq_domain *domain, struct device *dev,
 		if (args.np == irq_domain_get_of_node(domain)) {
 			if (WARN_ON(args.args_count != 1))
 				return -EINVAL;
-			dev_id = args.args[0];
+			*dev_id = args.args[0];
 			break;
 		}
 	} while (!ret);
 
+	return ret;
+}
+
+static int its_pmsi_prepare(struct irq_domain *domain, struct device *dev,
+			    int nvec, msi_alloc_info_t *info)
+{
+	struct msi_domain_info *msi_info;
+	u32 dev_id;
+	int ret;
+
+	msi_info = msi_get_domain_info(domain->parent);
+
+	ret = of_pmsi_get_dev_id(domain, dev, &dev_id);
 	if (ret)
 		return ret;
 
-- 
1.7.12.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/14] ACPI platform MSI, interrupt producer/consumer and its example mbi-gen Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:20 +0200
  [PATCH v3 01/14] ACPI: ARM64: IORT: minor cleanup for iort_match_node_callback() Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:20 +0200
  [PATCH v3 02/14] irqchip: gic-v3-its: keep the head file include in alphabetic order Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:20 +0200
  [PATCH v3 07/14] irqchip: gicv3-its: platform-msi: scan MADT to create platform msi domain Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:20 +0200
  [PATCH v3 14/14] irqchip: mbigen: Add ACPI support Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:20 +0200
  [PATCH v3 09/14] ACPI: platform: setup MSI domain for ACPI based platform device Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:20 +0200
  [PATCH v3 11/14] ACPI: irq: introduce interrupt producer Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:20 +0200
  [PATCH v3 08/14] ACPI: ARM64: IORT: rework iort_node_get_id() Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:20 +0200
  [PATCH v3 04/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_prepare() Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:20 +0200
  [PATCH v3 10/14] msi: platform: make platform_msi_create_device_domain() ACPI aware Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:20 +0200
  [PATCH v3 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:20 +0200
  [PATCH v3 12/14] irqchip: mbigen: drop module owner Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:20 +0200
  [PATCH v3 13/14] irqchip: mbigen: introduce mbigen_of_create_domain() Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:20 +0200
  [PATCH v3 03/14] ACPI: ARM64: IORT: add missing comment for iort_dev_find_its_id() Hanjun Guo <guohanjun@huawei.com> - 2016-10-25 17:30 +0200

csiph-web