Re: [PATCH] Input: gpio-keys - use module_platform_driver macro

From	Slawomir Stepien <sst@poczta.fm>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Input: gpio-keys - use module_platform_driver macro
Date	2016-10-27 21:20 +0200
Message-ID	<swYnw-60b-7@gated-at.bofh.it> (permalink)
References	<swU0z-38X-69@gated-at.bofh.it> <swW2l-4oW-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Oct 27, 2016 09:48, Dmitry Torokhov wrote:
> Hi Slawomir,

Hi Dmitry,

> > -late_initcall(gpio_keys_init);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> Because of this we can't switch to module_platform_driver(). The
> late_initcall was requirement of one of platforms because of the probe
> ordering issues. It may be resolved now with deferred probing, but you'd
> need to confirm with all the users.

I was unaware of that. Let me look in to that more deeply. At the moment I do
not have the knowledge what will be to correct solution for that.

> > -module_exit(gpio_keys_exit);
> > +module_platform_driver(gpio_keys_device_driver);
> >  
> >  MODULE_LICENSE("GPL");
> >  MODULE_AUTHOR("Phil Blundell <pb@handhelds.org>");
> 
> Thanks.

Thank you.

-- 
Slawomir Stepien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Input: gpio-keys - use module_platform_driver macro Slawomir Stepien <sst@poczta.fm> - 2016-10-27 16:40 +0200
  Re: [PATCH] Input: gpio-keys - use module_platform_driver macro Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-10-27 18:50 +0200
    Re: [PATCH] Input: gpio-keys - use module_platform_driver macro Slawomir Stepien <sst@poczta.fm> - 2016-10-27 21:20 +0200

csiph-web