[PATCH v2] irqchip/bcm2836: Prevent spurious interrupts

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	[PATCH v2] irqchip/bcm2836: Prevent spurious interrupts
Date	2016-10-27 20:30 +0200
Message-ID	<swXB7-5us-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Phil Elwell <phil@raspberrypi.org>

The old arch-specific IRQ macros included a dsb to ensure the
write to clear the mailbox interrupt completed before returning
from the interrupt. The BCM2836 irqchip driver needs the same
precaution to avoid spurious interrupts.

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/irqchip/irq-bcm2836.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c
index d96b2c947e74..93e3f7660c42 100644
--- a/drivers/irqchip/irq-bcm2836.c
+++ b/drivers/irqchip/irq-bcm2836.c
@@ -175,6 +175,7 @@ __exception_irq_entry bcm2836_arm_irqchip_handle_irq(struct pt_regs *regs)
 		u32 ipi = ffs(mbox_val) - 1;
 
 		writel(1 << ipi, mailbox0);
+		dsb(sy);
 		handle_IPI(ipi, regs);
 #endif
 	} else if (stat) {
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] irqchip/bcm2836: Prevent spurious interrupts Eric Anholt <eric@anholt.net> - 2016-10-27 20:30 +0200
  Re: [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts Thomas Gleixner <tglx@linutronix.de> - 2016-10-28 13:10 +0200
    Re: [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts Eric Anholt <eric@anholt.net> - 2016-10-28 18:00 +0200
      Re: [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts Thomas Gleixner <tglx@linutronix.de> - 2016-10-28 22:40 +0200
        Re: [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts Eric Anholt <eric@anholt.net> - 2016-10-31 19:00 +0100
          Re: [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts Thomas Gleixner <tglx@linutronix.de> - 2016-10-31 19:20 +0100

csiph-web