Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1510484

Re: [RFC PATCH 13/13] of: Remove unused variable overlay_symbols

From Frank Rowand <frowand.list@gmail.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 13/13] of: Remove unused variable overlay_symbols
Date 2016-10-27 19:00 +0200
Message-ID <swWc1-4su-3@gated-at.bofh.it> (permalink)
References <swh8R-2vP-3@gated-at.bofh.it> <swh8R-2vP-17@gated-at.bofh.it> <swUae-3cE-39@gated-at.bofh.it> <swVIZ-4ii-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 10/27/16 09:27, Frank Rowand wrote:
> On 10/27/16 07:41, Pantelis Antoniou wrote:
>> Hi Frank,
>>
>>
>>> On Oct 25, 2016, at 23:59 , frowand.list@gmail.com wrote:
>>>
>>> From: Frank Rowand <frank.rowand@am.sony.com>
>>>
>>> This unused variable is a reminder that symbols in overlays are
>>> not available to subsequent overlays.  If such a feature is
>>> desired then there are several ways it could be implemented.
>>>
>>
>> Please don’t apply that. There’s a patch that actually imports
>> the symbol table from overlays that subsequent operations
>> work.
>>
>> Please see:
>>
>> https://patchwork.kernel.org/patch/9104701/
> 
> Thanks for the pointer!  When the import symbols patch is applied
> then the comment in my patch header becomes incorrect.  I will
> change the patch comment to act is if the import symbols patch
> is in place.
> 
> But the node pointer that my patch removes is still not used
> for anything, even if the import symbols patch is applied.
> 
> Am I missing something?

I was missing a later patch in the symbol import patch set that
updated resolver.c to use the imported symbols.  I'll go look
at that.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH 13/13] of: Remove unused variable overlay_symbols frowand.list@gmail.com - 2016-10-25 23:10 +0200
  Re: [RFC PATCH 13/13] of: Remove unused variable overlay_symbols Pantelis Antoniou <panto@antoniou-consulting.com> - 2016-10-27 16:50 +0200
    Re: [RFC PATCH 13/13] of: Remove unused variable overlay_symbols Frank Rowand <frowand.list@gmail.com> - 2016-10-27 18:30 +0200
      Re: [RFC PATCH 13/13] of: Remove unused variable overlay_symbols Frank Rowand <frowand.list@gmail.com> - 2016-10-27 19:00 +0200
        Re: [RFC PATCH 13/13] of: Remove unused variable overlay_symbols Frank Rowand <frowand.list@gmail.com> - 2016-10-27 19:00 +0200

csiph-web