Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1510375

Re: [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Oct 26, 2016 at 10:55:28AM +0200, Maxime Ripard wrote:
> On Wed, Oct 26, 2016 at 12:00:30AM -0700, Alexandru Gagniuc wrote:

> > When DMA finally takes over, this fallback path is not mutually exclusive.

> I definitely agree, and we had this patch in the CHIP kernel for quite
> some time, working like a charm.

> I was planning to respin it in the next few days, glad to see you took
> care of it :)

> Mark, any comments on this? For the record, it already has my Acked-by.

Without knowing what the previous discussion was it's hard to comment,
it sounds like some prior review comments are just being ignored here
but since I'm not turning up anything with this subject line I've no
idea what that might have been (and that's very concerning in itself
given that this is apparently v7...).  I'm also concerned that there
isn't a version of this for sun6i, it's going to make all the
cut'n'pasting between the two drivers harder if we make changes in one
and not the other.

If the concern from the previous reviews to do with not using DMA is
there some reason it's hard to do DMA?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7] spi: sun4i: Allow transfers larger than FIFO size Alexandru Gagniuc <mr.nuke.me@gmail.com> - 2016-10-26 09:10 +0200
  [PATCH] spi: sun4i: Allow transfers larger than FIFO size Alexandru Gagniuc <mr.nuke.me@gmail.com> - 2016-10-26 09:10 +0200
    Applied "spi: sun4i: Allow transfers larger than FIFO size" to the spi tree Mark Brown <broonie@kernel.org> - 2016-10-29 20:20 +0200
  Re: [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size Mark Brown <broonie@kernel.org> - 2016-10-26 12:10 +0200
    Re: [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size Alex Gagniuc <mr.nuke.me@gmail.com> - 2016-10-26 18:10 +0200
      Re: [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size Mark Brown <broonie@kernel.org> - 2016-10-26 18:50 +0200
  Re: [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-27 00:20 +0200
    Re: [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size Mark Brown <broonie@kernel.org> - 2016-10-27 17:10 +0200
      Re: [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-10-27 23:30 +0200
        Re: [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size Mark Brown <broonie@kernel.org> - 2016-10-28 00:50 +0200
          Re: [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-02 18:50 +0100

csiph-web