Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1510224

Re: [PATCH 7/9] Input: wm97xx: split out touchscreen registering

Show all headers | View raw

On Wed, Oct 26, 2016 at 09:41:45PM +0200, Robert Jarzmik wrote:
> wm97xx-core does several things in it initialization :
>  - touchscreen input device setup
>  - battery device creation
> 
> As the wm97xx is actually a multi-function device handling an audio
> codec, a touchscreen, a gpio block and an ADC, reshape the probing to
> isolate what is truly input/touchscreen specific from the remaining
> part.
> 
> This is only code shuffling, there is no functional change.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
>  drivers/input/touchscreen/wm97xx-core.c | 193 ++++++++++++++++++--------------
>  1 file changed, 112 insertions(+), 81 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
> index 83cf11312fd9..50a110e2988b 100644
<snip>
> +static void wm97xx_remove_battery(struct wm97xx *wm)
> +{
> +	platform_device_put(wm->battery_dev);
> +}
<snip>
> @@ -724,10 +757,8 @@ static int wm97xx_remove(struct device *dev)
>  {
>  	struct wm97xx *wm = dev_get_drvdata(dev);
>  
> -	platform_device_unregister(wm->battery_dev);
> -	platform_device_unregister(wm->touch_dev);
> -	input_unregister_device(wm->input_dev);
> -	kfree(wm);
> +	wm97xx_remove_battery(wm);

The commit message says this is just shifting code around but the
platform_device_unregister for the battery_dev seems to have
turned into a platform_device_put here.

Thanks,
Charles

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] AC97 device/driver model revamp Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-26 21:50 +0200
  [PATCH 9/9] Input: wm97xx: add new AC97 bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-26 21:50 +0200
    Re: [PATCH 9/9] Input: wm97xx: add new AC97 bus support Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-10-27 11:20 +0200
  [PATCH 5/9] ASoC: pxa: switch to new ac97 bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-26 21:50 +0200
    Re: [PATCH 5/9] ASoC: pxa: switch to new ac97 bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-31 09:40 +0100
      Re: [PATCH 5/9] ASoC: pxa: switch to new ac97 bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2016-11-01 21:00 +0100
  [PATCH 1/9] ALSA: ac97: split out the generic ac97 registers Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-26 21:50 +0200
  [PATCH 2/9] ALSA: ac97: add an ac97 bus Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-26 21:50 +0200
    Re: [alsa-devel] [PATCH 2/9] ALSA: ac97: add an ac97 bus Lars-Peter Clausen <lars@metafoo.de> - 2016-11-08 14:40 +0100
      Re: [alsa-devel] [PATCH 2/9] ALSA: ac97: add an ac97 bus Robert Jarzmik <robert.jarzmik@free.fr> - 2016-11-08 22:30 +0100
        Re: [alsa-devel] [PATCH 2/9] ALSA: ac97: add an ac97 bus Lars-Peter Clausen <lars@metafoo.de> - 2016-11-09 14:20 +0100
          Re: [alsa-devel] [PATCH 2/9] ALSA: ac97: add an ac97 bus Robert Jarzmik <robert.jarzmik@free.fr> - 2016-11-09 22:30 +0100
            Re: [alsa-devel] [PATCH 2/9] ALSA: ac97: add an ac97 bus Lars-Peter Clausen <lars@metafoo.de> - 2016-11-10 12:40 +0100
  [PATCH 3/9] ASoC: add new ac97 bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-26 21:50 +0200
  [PATCH 4/9] ASoC: wm9713: add ac97 new bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-26 22:00 +0200
    Re: [PATCH 4/9] ASoC: wm9713: add ac97 new bus support Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-10-27 16:00 +0200
  [PATCH 7/9] Input: wm97xx: split out touchscreen registering Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-26 22:20 +0200
    Re: [PATCH 7/9] Input: wm97xx: split out touchscreen registering Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-10-27 16:10 +0200
      Re: [PATCH 7/9] Input: wm97xx: split out touchscreen registering Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-27 21:30 +0200
  [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-26 22:20 +0200
    Re: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2016-10-27 11:20 +0200

csiph-web