Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1510220

Re: [patch v1 2/2] drivers/platform/x86: add mlxcpld-hotplug driver registration to mlx-platform driver

From Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [patch v1 2/2] drivers/platform/x86: add mlxcpld-hotplug driver registration to mlx-platform driver
Date 2016-10-27 16:10 +0200
Message-ID <swTxy-2VB-85@gated-at.bofh.it> (permalink)
References <swTxy-2VB-87@gated-at.bofh.it>
Organization Intel Finland Oy

Show all headers | View raw


On Thu, 2016-10-27 at 13:59 +0000, vadimp@mellanox.com wrote:
> From: Vadim Pasternak <vadimp@mellanox.com>

Care to fix that ^^^ ? (Hint: it shouldn't be there if author and
submitter is the same guy)


> Add calls for mlxcpld-hotplug platform driver
> registration/unregistration
> and add platform hotplug data configurations.

Would you provide more information what is done, where it is described
in the specs and how user can utilize the change?

> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -37,8 +37,9 @@
>  #include <linux/i2c.h>
>  #include <linux/i2c-mux.h>
>  #include <linux/module.h>

> -#include <linux/platform_device.h>

This...

>  #include <linux/platform_data/i2c-mux-reg.h>
> +#include <linux/platform_data/mlxcpld-hotplug.h>


> +#include <linux/platform_device.h>

...and this doesn't belong to the patch.


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [patch v1 2/2] drivers/platform/x86: add mlxcpld-hotplug driver  registration to mlx-platform driver Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-10-27 16:10 +0200

csiph-web