Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1510237

Re: [RFC PATCH 0/4] Clean up watchdog handlers

Show all headers | View raw

On Wed, Oct 26, 2016 at 09:02:19AM -0700, Babu Moger wrote:
> This is an attempt to cleanup watchdog handlers. Right now,
> kernel/watchdog.c implements both softlockup and hardlockup detectors.
> Softlockup code is generic. Hardlockup code is arch specific. Some
> architectures don't use hardlockup detectors. They use their own watchdog
> detectors. To make both these combination work, we have numerous #ifdefs
> in kernel/watchdog.c.
> 
> We are trying here to make these handlers independent of each other.
> Also provide an interface for architectures to implement their own
> handlers. watchdog_nmi_enable and watchdog_nmi_disable will be defined
> as weak such that architectures can override its definitions.

Thanks for the patches Babu.  I will try to get to them today or tomorrow.

Cheers,
Don

> 
> Thanks to Don Zickus for his suggestions.
> Here is the previous discussion
> http://www.spinics.net/lists/sparclinux/msg16441.html
> 
> Babu Moger (4):
>   watchdog: Remove hardlockup handler references
>   watchdog: Move shared definitions to nmi.h
>   watchdog: Move hardlockup detector in separate file
>   sparc: Implement watchdog_nmi_enable and watchdog_nmi_disable
> 
>  arch/sparc/kernel/nmi.c |   44 ++++++++-
>  include/linux/nmi.h     |   19 ++++
>  kernel/Makefile         |    1 +
>  kernel/watchdog.c       |  276 ++---------------------------------------------
>  kernel/watchdog_hld.c   |  238 ++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 312 insertions(+), 266 deletions(-)
>  create mode 100644 kernel/watchdog_hld.c
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/4] Clean up watchdog handlers Babu Moger <babu.moger@oracle.com> - 2016-10-26 18:10 +0200
  [RFC PATCH 3/4] watchdog: Move hardlockup detector to separate file Babu Moger <babu.moger@oracle.com> - 2016-10-26 18:10 +0200
  [RFC PATCH 4/4] sparc: Implement watchdog_nmi_enable and watchdog_nmi_disable Babu Moger <babu.moger@oracle.com> - 2016-10-26 18:10 +0200
  Re: [RFC PATCH 0/4] Clean up watchdog handlers Don Zickus <dzickus@redhat.com> - 2016-10-27 16:20 +0200
  Re: [RFC PATCH 0/4] Clean up watchdog handlers Don Zickus <dzickus@redhat.com> - 2016-10-31 22:10 +0100
    Re: [RFC PATCH 0/4] Clean up watchdog handlers Babu Moger <babu.moger@oracle.com> - 2016-10-31 22:30 +0100
    Re: [RFC PATCH 0/4] Clean up watchdog handlers Babu Moger <babu.moger@oracle.com> - 2016-10-31 22:40 +0100
      Re: [RFC PATCH 0/4] Clean up watchdog handlers Don Zickus <dzickus@redhat.com> - 2016-11-01 14:30 +0100
        Re: [RFC PATCH 0/4] Clean up watchdog handlers Babu Moger <babu.moger@oracle.com> - 2016-11-01 16:10 +0100

csiph-web