Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1510115
| From | Sakari Ailus <sakari.ailus@iki.fi> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] [media] smiapp: make PM functions as __maybe_unused |
| Date | 2016-10-27 09:30 +0200 |
| Message-ID | <swNiq-7bf-19@gated-at.bofh.it> (permalink) |
| References | <swD9o-nA-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Arnd,
On Wed, Oct 26, 2016 at 10:38:01PM +0200, Arnd Bergmann wrote:
> The rework of the PM support has caused two functions to
> be orphaned when CONFIG_PM is disabled:
>
> media/i2c/smiapp/smiapp-core.c:1352:12: error: 'smiapp_power_off' defined but not used [-Werror=unused-function]
> media/i2c/smiapp/smiapp-core.c:1206:12: error: 'smiapp_power_on' defined but not used [-Werror=unused-function]
>
> This changes all four PM entry points to __maybe_unused and
> removes the #ifdef markers for consistency. This avoids the
> warnings even when something changes again.
>
> Fixes: cbba45d43631 ("[media] smiapp: Use runtime PM")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
The power-on sequence is in fact mandatory as it involves writing the
initial configuration to the sensor as well.
Instead, I believe the correct fix is to make the driver depend on
CONFIG_PM.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] [media] smiapp: make PM functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-10-26 22:40 +0200
Re: [PATCH] [media] smiapp: make PM functions as __maybe_unused Sakari Ailus <sakari.ailus@iki.fi> - 2016-10-27 09:30 +0200
Re: [PATCH] [media] smiapp: make PM functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-10-27 09:50 +0200
Re: [PATCH] [media] smiapp: make PM functions as __maybe_unused Sakari Ailus <sakari.ailus@iki.fi> - 2016-10-27 16:10 +0200
csiph-web