Re: [PATCH] x86: quirks: hide maybe-uninitialized warning

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86: quirks: hide maybe-uninitialized warning
Date	2016-10-27 08:30 +0200
Message-ID	<swMmm-6xt-9@gated-at.bofh.it> (permalink)
References	<svPvY-14z-27@gated-at.bofh.it> <swCwG-8id-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Bjorn Helgaas <helgaas@kernel.org> wrote:

> On Mon, Oct 24, 2016 at 05:33:18PM +0200, Arnd Bergmann wrote:
> > gcc -Wmaybe-uninitialized detects that quirk_intel_brickland_xeon_ras_cap
> > uses uninitialized data when CONFIG_PCI is not set:
> > 
> > arch/x86/kernel/quirks.c: In function ‘quirk_intel_brickland_xeon_ras_cap’:
> > arch/x86/kernel/quirks.c:641:13: error: ‘capid0’ is used uninitialized in this function [-Werror=uninitialized]
> > 
> > However, the function is also not called in this configuration, so we
> > can avoid the warning by moving the existing #ifdef to cover it as well.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> This fixes 3637efb00864 ("x86/mce: Add PCI quirks to identify Xeons with
> machine check recovery"), which appeared in v4.9-rc1.  I assume it will be
> merged for v4.9 via the x86 tree, as 3637efb00864 was.
> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Yeah, that's the plan - thanks!

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] x86: quirks: hide maybe-uninitialized warning Arnd Bergmann <arnd@arndb.de> - 2016-10-24 17:40 +0200
  [tip:x86/urgent] x86/quirks: Hide maybe-uninitialized warning tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2016-10-25 12:40 +0200
  Re: [PATCH] x86: quirks: hide maybe-uninitialized warning Bjorn Helgaas <helgaas@kernel.org> - 2016-10-26 22:00 +0200
    Re: [PATCH] x86: quirks: hide maybe-uninitialized warning Ingo Molnar <mingo@kernel.org> - 2016-10-27 08:30 +0200

csiph-web