Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1510034

Re: [PATCH v2 2/4] usb: musb: core: added helper function for parsing DT

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From David Lechner <david@lechnology.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/4] usb: musb: core: added helper function for parsing DT
Date Thu, 27 Oct 2016 05:30:01 +0200
Message-ID <swJy9-4CV-1@gated-at.bofh.it> (permalink)
References <swy01-5vO-1@gated-at.bofh.it> <swy01-5vO-9@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jMOkeJ6ZTHQ6wQdh9MDRUIX/UilGHh/C0JXtFph0xrA=; b=LbachvcGFWncAJ8tfZQMO6hAck 7mUay1LUVz7qCMG+i1VhJXe8+raopI9z++dAPCuribpQq0P4jnUFEQAJJDkJWyvpGEgNj4E7la+1K Mswep1ui/Opmh0g87JRqkozlqsu8kM0DEX3lhSw4U3uKK4Z+OjbJcbnh4FC68iq4eTEOozwwwHJ3F 3Y8vF2JO22ydtohuVEJDamG21J9utwfsbQd2lwv+PMDTSez8iayAA2nA2ccZvLBZKiNDyHLUi9eIx cQytd6vRl/FWxgTg18AFwADa6Wp6UULYQUImlGbYPA9JkGRXXQDysLVLb+Ldclp/HHiQobu3Qw+LP sLn8IgJQ==;
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0
MIME-Version 1.0
Content-Type text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding 7bit
X-Antiabuse This header was added to track abuse, please include it with any abuse report
X-Antiabuse Primary Hostname - vern.gendns.com
X-Antiabuse Original Domain - vger.kernel.org
X-Antiabuse Originator/Caller UID/GID - [47 12] / [47 12]
X-Antiabuse Sender Address Domain - lechnology.com
X-Get-Message-Sender-Via vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed
X-Authenticated-Sender vern.gendns.com: davidmain@lechnology.com
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 70
Organization linux.* mail to news gateway
X-Original-Cc devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Petr Kulhavy <petr@barix.com>, linux-arm-kernel@lists.infradead.org
X-Original-Date Wed, 26 Oct 2016 22:27:13 -0500
X-Original-Message-ID <0324b2c8-ef22-2ef5-1fcd-d1a0807e549e@lechnology.com>
X-Original-References <1477494237-22831-1-git-send-email-abailon@baylibre.com> <1477494237-22831-3-git-send-email-abailon@baylibre.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1510034

Show key headers only | View raw


On 10/26/2016 10:03 AM, Alexandre Bailon wrote:
> From: Petr Kulhavy <petr@barix.com>
>
> This adds the function musb_get_mode() to get the DT property "dr_mode"
>
> Signed-off-by: Petr Kulhavy <petr@barix.com>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> ---
>  drivers/usb/musb/musb_core.c | 19 +++++++++++++++++++
>  drivers/usb/musb/musb_core.h |  5 +++++
>  2 files changed, 24 insertions(+)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 27dadc0..bba07e7 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -100,6 +100,7 @@
>  #include <linux/io.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/usb.h>
> +#include <linux/usb/of.h>
>
>  #include "musb_core.h"
>  #include "musb_trace.h"
> @@ -130,6 +131,24 @@ static inline struct musb *dev_to_musb(struct device *dev)
>  	return dev_get_drvdata(dev);
>  }
>
> +enum musb_mode musb_get_mode(struct device *dev)
> +{
> +	enum usb_dr_mode mode;
> +
> +	mode = usb_get_dr_mode(dev);
> +	switch (mode) {
> +	case USB_DR_MODE_HOST:
> +		return MUSB_HOST;
> +	case USB_DR_MODE_PERIPHERAL:
> +		return MUSB_PERIPHERAL;
> +	case USB_DR_MODE_OTG:
> +	case USB_DR_MODE_UNKNOWN:
> +	default:
> +		return MUSB_OTG;
> +	}
> +}
> +EXPORT_SYMBOL_GPL(musb_get_mode);
> +
>  /*-------------------------------------------------------------------------*/
>
>  #ifndef CONFIG_BLACKFIN
> diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h
> index 2cb88a49..a406468 100644
> --- a/drivers/usb/musb/musb_core.h
> +++ b/drivers/usb/musb/musb_core.h
> @@ -617,4 +617,9 @@ static inline void musb_platform_post_root_reset_end(struct musb *musb)
>  		musb->ops->post_root_reset_end(musb);
>  }
>
> +/* gets the "dr_mode" property from DT and converts it into musb_mode
> + * if the property is not found or not recognized returns MUSB_OTG
> + */
> +extern enum musb_mode musb_get_mode(struct device *dev);
> +
>  #endif	/* __MUSB_CORE_H__ */
>

Tested working on LEGO MINDSTORMS EV3 using dr_mode = "peripheral" and 
no vbus-supply.

Tested-By: David Lechner <david@lechnology.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/4] Add DT support for DA8xx Alexandre Bailon <abailon@baylibre.com> - 2016-10-26 17:10 +0200
  [PATCH v2 2/4] usb: musb: core: added helper function for parsing DT Alexandre Bailon <abailon@baylibre.com> - 2016-10-26 17:10 +0200
    Re: [PATCH v2 2/4] usb: musb: core: added helper function for parsing  DT David Lechner <david@lechnology.com> - 2016-10-27 05:30 +0200
  [PATCH v2 1/4] dt/bindings: Add binding for the DA8xx MUSB driver Alexandre Bailon <abailon@baylibre.com> - 2016-10-26 17:10 +0200
  [PATCH v2 3/4] usb: musb: da8xx: Add DT support for the DA8xx driver Alexandre Bailon <abailon@baylibre.com> - 2016-10-26 17:10 +0200
    Re: [PATCH v2 3/4] usb: musb: da8xx: Add DT support for the DA8xx  driver David Lechner <david@lechnology.com> - 2016-10-27 05:30 +0200
  [PATCH v2 4/4] ARM: dts: da850: Add the usb otg device node Alexandre Bailon <abailon@baylibre.com> - 2016-10-26 17:10 +0200

csiph-web