Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1509869

Re: [PATCH 0/2] KVM: x86: emulate fxsave and fxrstor

Show all headers | View raw

On 10/26/16 22:50, Radim Krčmář wrote:
> [1/2] adds the emulation (and could be split into two patches if you'd like),
> [2/2] just refactors the code.
> 
> This should fix an issue that users are hitting.  Laszlo found several reports:
>  - https://bugs.launchpad.net/qemu/+bug/1623276
>  - https://bugzilla.proxmox.com/show_bug.cgi?id=1182
>  - https://bugs.archlinux.org/task/50778
> 
> I have only tested it with a simple kvm-unit-tests, though.  Reproducing the
> iPXE issue is on the way ...
> 
> 
> Radim Krčmář (2):
>   KVM: x86: emulate fxsave and fxrstor
>   KVM: x86: save one bit in ctxt->d
> 
>  arch/x86/kvm/emulate.c | 110 ++++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 94 insertions(+), 16 deletions(-)
> 

I was just about to post iPXE patches that would disable the FXSAVE /
FXRSTOR instructions in the CONFIG=qemu build (*), but you beat me to it
with the KVM emulation code ;)

(*) If you look at the iPXE commit that added them, they are a
workaround for a Tivoli VMM bug; i.e., irrelevant for QEMU/KVM guests.

... Actually, those iPXE patches that conditionalize FXSAVE / FXRSTOR
may still make sense -- we can rebuild iPXE, and bundle the refreshed
binaries with QEMU v2.7.1, and swiftly at that. Whereas the KVM patches
could take more time to propagate to users?... Not sure. What do you
guys think?

Thanks
Laszlo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] KVM: x86: emulate fxsave and fxrstor Radim Krčmář <rkrcmar@redhat.com> - 2016-10-26 23:00 +0200
  [PATCH 2/2] KVM: x86: save one bit in ctxt->d Radim Krčmář <rkrcmar@redhat.com> - 2016-10-26 23:00 +0200
  Re: [PATCH 0/2] KVM: x86: emulate fxsave and fxrstor Laszlo Ersek <lersek@redhat.com> - 2016-10-26 23:50 +0200
    Re: [PATCH 0/2] KVM: x86: emulate fxsave and fxrstor Radim Krčmář <rkrcmar@redhat.com> - 2016-10-27 18:50 +0200
      Re: [PATCH 0/2] KVM: x86: emulate fxsave and fxrstor Laszlo Ersek <lersek@redhat.com> - 2016-10-27 19:10 +0200

csiph-web