Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1509827

Re: [PATCH 1/2] phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips

Path csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips
Date Wed, 26 Oct 2016 23:20:01 +0200
Message-ID <swDM5-Ri-5@gated-at.bofh.it> (permalink)
References <su0ca-2v4-35@gated-at.bofh.it> <su1Bg-3zK-39@gated-at.bofh.it>
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/Q0WlR9jPhxW1Hfd65UZqYwm0F0ru/nHy+aoxOTm+oI=; b=M3cJqC/ccqxTiTdis+RxnAkLoAzdlut0zUZhYGuAoTq6XZ8Clt+jQ49UyiNDbT1jdD 47aXDrSboB5Y7BXaGsNSbv4EZOMmWw8/VBetcLZofeeY1ofHHvnbhseLmdBb3D66ygdp 9bj/ns6mYxIWHNKvk7EKZF4YFhVRtzDimWTFXBggqsSqJ3Q7BfHe0ts1wj8rR8qkpOse HHPFguX0HvsUCfNfCAG9JPIum+/LmUe8OmzdqMreB8dL3nlky4AYUorh30MSVX4R6BDT F/+BjKRZkEbC1PeebPSZajRKbioZ7ggd/+Z5uqA46cJjdE++A+whkWsYEM+g+PDRTAdo PdAQ==
X-Gm-Message-State ABUngvd34OccI+Ia7FtxYJ8h+g7JOO/VTWwNMeJwu7JzwkveQUw0l9eeXFB4t9LNoKhx9Q==
X-Received by 10.157.58.3 with SMTP id j3mr3490652otc.194.1477516572362; Wed, 26 Oct 2016 14:16:12 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.6.2-neo (2016-08-21)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 70
Organization linux.* mail to news gateway
X-Original-Cc kishon@ti.com, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
X-Original-Date Wed, 26 Oct 2016 16:16:11 -0500
X-Original-Message-ID <20161026211611.3rl7mas75ju4x77w@rob-hp-laptop>
X-Original-References <1476873827-7191-1-git-send-email-vivek.gautam@codeaurora.org> <1476873827-7191-2-git-send-email-vivek.gautam@codeaurora.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1509827

Show key headers only | View raw


On Wed, Oct 19, 2016 at 04:13:46PM +0530, Vivek Gautam wrote:
> PHY transceiver driver for QUSB2 phy controller that provides
> HighSpeed functionality for DWC3 controller present on
> Qualcomm chipsets.
> 
> This driver is based on phy-msm-qusb driver available in
> msm-4.4 kernel @codeaurora[1]
> 
> [1] https://source.codeaurora.org/quic/la/kernel/msm-4.4/log/?h=caf/3.18/msm-3.18
> 
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  .../devicetree/bindings/phy/qcom-qusb2-phy.txt     |  37 ++

It's preferred the bindings are a separate patch.

>  drivers/phy/Kconfig                                |  10 +
>  drivers/phy/Makefile                               |   1 +
>  drivers/phy/phy-qcom-qusb2.c                       | 577 +++++++++++++++++++++
>  4 files changed, 625 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt
>  create mode 100644 drivers/phy/phy-qcom-qusb2.c
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt
> new file mode 100644
> index 0000000..97c9ce7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt
> @@ -0,0 +1,37 @@
> +Qualcomm QUSB2 phy controller
> +=============================
> +
> +QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets.
> +
> +Required properties:
> + - compatible: compatible list, contains "qcom,msm8996-qusb2-phy".
> + - reg: offset and length of the PHY register set.
> + - #phy-cells: must be 0.
> +
> + - clocks: a list of phandles and clock-specifier pairs,
> +	   one for each entry in clock-names.
> + - clock-names: must be "cfg_ahb" for phy config clock,
> +			"ref_clk" for 19.2 MHz ref clk,
> +			"ref_clk_src" reference clock source.
> +			"iface" for phy interface clock (Optional).
> +
> + - vdd-phy-supply: Phandle to a regulator supply to PHY core block.
> + - vdda-pll-supply: Phandle to 1.8V regulator supply to PHY refclk pll block.
> + - vdda-phy-dpdm: Phandle to 3.1V regulator supply to Dp/Dm port signals.
> +
> + - resets: a list of phandles and reset controller specifier pairs,
> +	   one for each entry in reset-names.
> + - reset-names: must be "phy" for reset of phy block.
> +
> +Optional properties:
> + - nvmem-cells: a list of phandles to nvmem cells that contain fused
> +		tuning parameters for qusb2 phy, one for each entry
> +		in nvmem-cell-names.
> + - nvmem-cell-names: must be "tune2_hstx_trim_efuse" for cell containing
> +		     HS Tx trim value.
> + - qcom,hstx-trim-bit-offset: bit offset within nvmem cell for
> +			      HS Tx trim value.
> + - qcom,hstx-trim-bit-len: bit length of HS Tx trim value within nvmem cell.

When does this change? Why is it not just a different nvmem cell?

> +
> + - qcom,tcsr-syscon: Phandle to TCSR syscon register region.
> + - qcom,phy-clk-scheme: Offset to TCSR_PHY_CLK_SCHEME_SEL register.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] phy: USB and PCIe phy drivers for Qcom chipsets Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-19 18:10 +0200
  [PATCH 1/2] phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-19 18:10 +0200
    Re: [PATCH 1/2] phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-20 06:20 +0200
    Re: [PATCH 1/2] phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom  chips Kishon Vijay Abraham I <kishon@ti.com> - 2016-10-26 22:00 +0200
      Re: [PATCH 1/2] phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-11-02 10:00 +0100
    Re: [PATCH 1/2] phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom  chips Rob Herring <robh@kernel.org> - 2016-10-26 23:20 +0200
      Re: [PATCH 1/2] phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-11-02 09:20 +0100
  Re: [PATCH 2/2] phy: qcom-qmp: new qmp phy driver for qcom-chipsets Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-10-20 06:20 +0200
  Re: [PATCH 2/2] phy: qcom-qmp: new qmp phy driver for qcom-chipsets Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-10-26 16:00 +0200
    Re: [PATCH 2/2] phy: qcom-qmp: new qmp phy driver for qcom-chipsets Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-11-02 08:30 +0100
      Re: [PATCH 2/2] phy: qcom-qmp: new qmp phy driver for qcom-chipsets Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-11-02 10:40 +0100
  Re: [PATCH 2/2] phy: qcom-qmp: new qmp phy driver for qcom-chipsets Kishon Vijay Abraham I <kishon@ti.com> - 2016-10-26 22:20 +0200
    Re: [PATCH 2/2] phy: qcom-qmp: new qmp phy driver for qcom-chipsets Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-11-10 10:10 +0100
  Re: [PATCH 2/2] phy: qcom-qmp: new qmp phy driver for qcom-chipsets Rob Herring <robh@kernel.org> - 2016-10-26 23:20 +0200
    Re: [PATCH 2/2] phy: qcom-qmp: new qmp phy driver for qcom-chipsets Vivek Gautam <vivek.gautam@codeaurora.org> - 2016-11-02 08:30 +0100

csiph-web