Re: [RFC PATCH 4/5] w1: add a callback to call slave when a new device is connected

From	Antoine Tenart <antoine.tenart@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 4/5] w1: add a callback to call slave when a new device is connected
Date	2016-10-26 19:40 +0200
Message-ID	<swAlc-6WH-25@gated-at.bofh.it> (permalink)
References	<swxQl-57S-5@gated-at.bofh.it> <swxQl-57S-3@gated-at.bofh.it> <swzyO-6qe-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hello Mathieu,

On Wed, Oct 26, 2016 at 10:42:28AM -0600, Mathieu Poirier wrote:
> On 26 October 2016 at 08:57, Antoine Tenart
> <antoine.tenart@free-electrons.com> wrote:
> >                 }
> > +               if (fops->callback) {
> > +                       err = fops->callback(sl);
> > +                       /*
> > +                        * Do not return an error as the slave driver correctly
> > +                        * probed.
> > +                        */
> 
> I don't get this part.  What's the point of calling a callback if a
> failure is not important - maybe I'm just missing something.
> 
> > +                       if (err)
> > +                               dev_err(&sl->dev,
> > +                                       "callback call failed. err=%d\n", err);
> > +               }

In our case it can be not that important: if we fail to apply an
overlay, we can still use the w1 interfaces to access the eeprom.

Anyway, all those errors weren't taken into account by the w1 framework
before (see my other patch). Also, the w1 patches are given for the
example and could be improved. Part of the reason is the w1 framework
itself :-)

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 4/5] w1: add a callback to call slave when a new device is connected Antoine Tenart <antoine.tenart@free-electrons.com> - 2016-10-26 17:00 +0200
  Re: [RFC PATCH 4/5] w1: add a callback to call slave when a new  device is connected Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-10-26 18:50 +0200
    Re: [RFC PATCH 4/5] w1: add a callback to call slave when a new  device is connected Antoine Tenart <antoine.tenart@free-electrons.com> - 2016-10-26 19:40 +0200

csiph-web