Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1508215

Re: [PATCH 1/2] x86/io: add interface to reserve io memtype for a resource range. (v1.1)

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] x86/io: add interface to reserve io memtype for a resource range. (v1.1)
Date 2016-10-25 13:20 +0200
Message-ID <sw7VT-4Qh-3@gated-at.bofh.it> (permalink)
References <svH5n-3Tr-1@gated-at.bofh.it> <svH5o-3Tr-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, 24 Oct 2016, Dave Airlie wrote:
> A recent change to the mm code in:
> 87744ab3832b83ba71b931f86f9cfdb000d07da5

nit: 12 digits of the SHA1 are sufficient :)

> +int arch_io_reserve_memtype_wc(resource_size_t start, resource_size_t size)
> +{
> +	enum page_cache_mode type = _PAGE_CACHE_MODE_WC;

Empty line between variable declaration and code please

> +	return io_reserve_memtype(start, start + size, &type);

Other than that:

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

x86 PAT memtype regression fixes (with extra cc's) Dave Airlie <airlied@redhat.com> - 2016-10-24 08:40 +0200
  [PATCH 2/2] drm/drivers: add support for using the arch wc mapping API. Dave Airlie <airlied@redhat.com> - 2016-10-24 08:40 +0200
    Re: [PATCH 2/2] drm/drivers: add support for using the arch wc  mapping API. Christian König <deathsimple@vodafone.de> - 2016-10-24 11:30 +0200
  [PATCH 1/2] x86/io: add interface to reserve io memtype for a resource range. (v1.1) Dave Airlie <airlied@redhat.com> - 2016-10-24 08:40 +0200
    Re: [PATCH 1/2] x86/io: add interface to reserve io memtype for a  resource range. (v1.1) Ingo Molnar <mingo@kernel.org> - 2016-10-25 11:50 +0200
    Re: [PATCH 1/2] x86/io: add interface to reserve io memtype for a  resource range. (v1.1) Thomas Gleixner <tglx@linutronix.de> - 2016-10-25 13:20 +0200
    Re: [PATCH 1/2] x86/io: add interface to reserve io memtype for a  resource range. (v1.1) "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-10-25 19:40 +0200
      Re: [PATCH 1/2] x86/io: add interface to reserve io memtype for a  resource range. (v1.1) Daniel Vetter <daniel@ffwll.ch> - 2016-10-26 07:50 +0200
        Re: [PATCH 1/2] x86/io: add interface to reserve io memtype for a  resource range. (v1.1) Dave Airlie <airlied@gmail.com> - 2016-10-26 08:20 +0200
          Re: [PATCH 1/2] x86/io: add interface to reserve io memtype for a  resource range. (v1.1) Daniel Vetter <daniel@ffwll.ch> - 2016-10-26 09:10 +0200
    [PATCH] x86/pat, mm: Make track_pfn_insert() return void Borislav Petkov <bp@alien8.de> - 2016-10-26 19:50 +0200

csiph-web