Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts

From	Sekhar Nori <nsekhar@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts
Date	2016-10-25 13:00 +0200
Message-ID	<sw7Cy-4uH-29@gated-at.bofh.it> (permalink)
References	(1 earlier) <suMTw-Zb-27@gated-at.bofh.it> <svMeK-7pR-11@gated-at.bofh.it> <svPPj-1bs-3@gated-at.bofh.it> <svTzz-3Fg-23@gated-at.bofh.it> <svUYG-4HF-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday 25 October 2016 02:50 AM, David Lechner wrote:
> On 10/24/2016 02:50 PM, David Lechner wrote:
>> On 10/24/2016 10:50 AM, David Lechner wrote:
>>> On 10/24/2016 06:58 AM, Sekhar Nori wrote:
>>>> On Saturday 22 October 2016 12:06 AM, David Lechner wrote:
>>>>
>>>>> +&ehrpwm1 {
>>>>> +    status = "disabled";
>>>>
>>>> Hmm, disabled? Can you add this node when you actually use it?
>>>
>>> Not sure why I have this disabled. Like the gpios, the pwms can be used
>>> via sysfs, so I would like to leave them.
>>>
>>
>> Now I remember why these are disabled. The clock matching is broken.
>> Only the first ehrpwm and the first ecap get clocks. The others fail.
>>
>> I can change these to "okay". It will just result in a kernel error
>> message until the clocks are fixed.
>>
> 
> correction: it is not the clocks that are broken. it is the device names.
> 
> In  arch/arm/mach-davinci/da8xx-dt.c, we have...
> 
> 
>     OF_DEV_AUXDATA("ti,da850-ehrpwm", 0x01f00000, "ehrpwm", NULL),
>     OF_DEV_AUXDATA("ti,da850-ehrpwm", 0x01f02000, "ehrpwm", NULL),
>     OF_DEV_AUXDATA("ti,da850-ecap", 0x01f06000, "ecap", NULL),
>     OF_DEV_AUXDATA("ti,da850-ecap", 0x01f07000, "ecap", NULL),
>     OF_DEV_AUXDATA("ti,da850-ecap", 0x01f08000, "ecap", NULL),
> 
> 
> Which causes each device to have the same device node name. This causes
> sysfs errors because it is trying to register a second device at the
> same sysfs path.
> 
> If you change the names here, then the device do not work because the
> clock lookup fails.

Yeah, this is incorrect (I should have caught it in review). The device
id should have been present in the lookup. Can you fix auxdata and clock
lookup too and send a separate patch? Its probably a v4.9-rc candidate.

Thanks,
Sekhar

Thread

[PATCH 0/5] Support for LEGO MINDSTORTMS EV3 David Lechner <david@lechnology.com> - 2016-10-21 20:40 +0200
  [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts David Lechner <david@lechnology.com> - 2016-10-21 20:40 +0200
    Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts Kevin Hilman <khilman@baylibre.com> - 2016-10-21 21:20 +0200
    Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts Sekhar Nori <nsekhar@ti.com> - 2016-10-24 14:10 +0200
      Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts David Lechner <david@lechnology.com> - 2016-10-24 18:00 +0200
        Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts David Lechner <david@lechnology.com> - 2016-10-24 22:00 +0200
          Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts David Lechner <david@lechnology.com> - 2016-10-24 23:30 +0200
            Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts Sekhar Nori <nsekhar@ti.com> - 2016-10-25 13:00 +0200
              Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts David Lechner <david@lechnology.com> - 2016-10-25 17:50 +0200
        Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts David Lechner <david@lechnology.com> - 2016-10-25 05:00 +0200
  [PATCH 1/5] ARM: davinci: Compile MMC in kernel David Lechner <david@lechnology.com> - 2016-10-21 20:40 +0200
    Re: [PATCH 1/5] ARM: davinci: Compile MMC in kernel Sekhar Nori <nsekhar@ti.com> - 2016-10-26 13:40 +0200
  Re: [PATCH 0/5] Support for LEGO MINDSTORTMS EV3 lsorense@csclub.uwaterloo.ca (Lennart Sorensen) - 2016-10-21 20:50 +0200

csiph-web