Re: [PATCH/RFT v2 13/17] USB: da8xx: use ohci priv data instead of globals

From	Axel Haslam <ahaslam@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH/RFT v2 13/17] USB: da8xx: use ohci priv data instead of globals
Date	2016-10-25 12:00 +0200
Message-ID	<sw6Gt-3S0-9@gated-at.bofh.it> (permalink)
References	<svQBH-1Ks-3@gated-at.bofh.it> <svQBH-1Ks-7@gated-at.bofh.it> <svYzf-72Z-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Oct 25, 2016 at 3:12 AM, David Lechner <david@lechnology.com> wrote:
> On 10/24/2016 11:46 AM, ahaslam@baylibre.com wrote:
>>
>> From: Axel Haslam <ahaslam@baylibre.com>
>> >  static const struct ohci_driver_overrides da8xx_overrides __initconst =
>> > {
>> -       .reset          = ohci_da8xx_reset
>> +       .reset          = ohci_da8xx_reset,
>> +       .extra_priv_size = sizeof(struct da8xx_ohci_hcd),
>
>
> nit: since you are changing both lines anyway, you might as well make the
> ='s line up.

ok, will do.

>
>>  };
>>
>>  /*
>>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH/RFT v2 13/17] USB: da8xx: use ohci priv data instead of globals ahaslam@baylibre.com - 2016-10-24 18:50 +0200
  Re: [PATCH/RFT v2 13/17] USB: da8xx: use ohci priv data instead of  globals David Lechner <david@lechnology.com> - 2016-10-25 03:20 +0200
    Re: [PATCH/RFT v2 13/17] USB: da8xx: use ohci priv data instead of globals Axel Haslam <ahaslam@baylibre.com> - 2016-10-25 12:00 +0200

csiph-web