Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1508063

Re: [PATCH] drm/amd/powerplay: mark symbols static where possible

Show all headers | View raw

On Tuesday, October 25, 2016 10:31:21 AM CEST Baoyou Xie wrote:
> On 25 October 2016 at 04:51, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote:
> > The function has no callers, so the easiest way would be to remove it
> > entirely, but it's possible that there are plans to add users soon.
> >
> > It was assumed that this function will be used soon, so this patch remains
> it.
> if it still not be used in 4.10, then we can remove it.
> is it right?

There is no such rule in general, it's up to the maintainer and
it depends on the specific reason for why the function ended up
being unused in the first place.

However, we can expect the maintainer to come up with some solution
to address the warning. Possible options include:

- calling the function from where it was meant to be used
- removing the function
- adding __maybe_unused
- adding an #if 0

I have not looked at this specific example and do not know
which of them would be appropriate here. If you look at the
output of 'git log -p drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c'
you might find it out yourself.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/amd/powerplay: mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-10-22 11:00 +0200
  Re: [PATCH] drm/amd/powerplay: mark symbols static where possible Edward O'Callaghan <funfunctor@folklore1984.net> - 2016-10-22 11:30 +0200
  Re: [PATCH] drm/amd/powerplay: mark symbols static where possible Alex Deucher <alexdeucher@gmail.com> - 2016-10-24 18:40 +0200
    Re: [PATCH] drm/amd/powerplay: mark symbols static where possible Arnd Bergmann <arnd@arndb.de> - 2016-10-24 21:50 +0200
      RE: [PATCH] drm/amd/powerplay: mark symbols static where possible "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2016-10-24 22:30 +0200
        Re: [PATCH] drm/amd/powerplay: mark symbols static where possible Arnd Bergmann <arnd@arndb.de> - 2016-10-24 22:50 +0200
          Re: [PATCH] drm/amd/powerplay: mark symbols static where possible Daniel Vetter <daniel@ffwll.ch> - 2016-10-25 08:50 +0200
            Re: [PATCH] drm/amd/powerplay: mark symbols static where possible Christian König <deathsimple@vodafone.de> - 2016-10-25 09:10 +0200
              Re: [PATCH] drm/amd/powerplay: mark symbols static where possible Daniel Vetter <daniel@ffwll.ch> - 2016-10-25 10:20 +0200
  Re: [PATCH] drm/amd/powerplay: mark symbols static where possible Arnd Bergmann <arnd@arndb.de> - 2016-10-24 23:00 +0200
    Re: [PATCH] drm/amd/powerplay: mark symbols static where possible Arnd Bergmann <arnd@arndb.de> - 2016-10-25 10:20 +0200
      RE: [PATCH] drm/amd/powerplay: mark symbols static where possible "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2016-10-25 22:10 +0200

csiph-web