Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1508040

Re: [PATCH 11/14] staging: fsl-mc: message cleanup

Show all headers | View raw

On Mon, Oct 17, 2016 at 01:43:39PM -0500, Stuart Yoder wrote:
> Cleanup and clarify messages
>   -use "fsl-mc" prefix for all messages that don't come from dev_*
>    functions

Nope, please use the proper pr_fmt() #define at the top of the file,
that way you don't have to put the string into all pr_* calls.

>   -remove unnecessary verbosity to make things clearer
>   -use explicit __func__ arguments to clarify some error messages
>   -improve misc wording for clarity

That's alot of different things.  Again, if you have to list the
different things you do in a patch, that means you should break it up
into smaller ones.  Yes, this is a "tiny" patch, but I can't take it
because of the above problem, while if you had broken it up into smaller
ones, I could have taken all but the pr_* changes :(

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 11/14] staging: fsl-mc: message cleanup Greg KH <gregkh@linuxfoundation.org> - 2016-10-25 09:50 +0200

csiph-web